Move the exception handling logic from K to kevm-pyk #2816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the logic that handles the exceptions in conformance tests and moving it from driver.md to the kevm-pyk test harness.
changes in driver.md:
exceptionproduction fromEthereumCommandsort and its associated rules from driver.md.statusproduction from driver.md#allPostKeyssetchanges to the GST iterator in kevm-pyk/src/kevm_pyk/interpreter.py:
added a
_resolve_exceptionfunction that reads theexpectExceptionandhasBigIntfields from the GST test json.the iterator now returns if the test is expected to fail.
changes in kevm-pyk/src/tests/utils.py:
optimizing the
_testfunction:adding new functions to fetch the cell value.
updating the
_assert_exit_code_zerofunction to check if the test should throw an exception when the interpreter returns a non-zero exit code.Removing the
expectExceptionfrom a test that is supposed to fail is caught.