Skip to content

Conversation

@jberthold
Copy link
Member

Since we cannot reliably determine the discriminant bit width from layout, we:

  • set bitwidth to 0 for values obtained from the RValue Discriminant
  • allow comparisons using these discriminant values on either side of comparison operations
  • allow these discriminants to be used in switchInt terminators

@jberthold jberthold marked this pull request as ready for review October 31, 2025 04:46
Copy link
Collaborator

@dkcumming dkcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we might want an issue that is backlog saying to see if we can get to the bottom of what the type will really be (sounds like a big time sink of research and confusion)

@jberthold jberthold merged commit d6a8dac into master Oct 31, 2025
7 checks passed
@jberthold jberthold deleted the bitwidth-zero-for-discriminants branch October 31, 2025 07:59
@jberthold
Copy link
Member Author

Looks good, we might want an issue that is backlog saying to see if we can get to the bottom of what the type will really be (sounds like a big time sink of research and confusion)

#793 created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants