Skip to content

Conversation

@Mortano
Copy link
Contributor

@Mortano Mortano commented Sep 19, 2025

This fixes UB when using the ArcBlock<T> and BoxBlock<T> types together with the Stack type, as it occurs in the ArcPoolImpl and BoxPoolImpl types. The underlying cause for the UB was a wrongly initialized UnionNode, as was discussed in #605 . This also required that the functions of the Node trait are unsafe, but this should not be a breaking API change as that trait is never exported from the pool module

Copy link
Contributor

@sgued sgued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot for the audit of the unsafe code. Already yielding results!

@sgued sgued mentioned this pull request Oct 28, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants