Fix UB in pool module when using ArcBlock<T> and BoxBlock<T>
#612
+63
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes UB when using the
ArcBlock<T>andBoxBlock<T>types together with theStacktype, as it occurs in theArcPoolImplandBoxPoolImpltypes. The underlying cause for the UB was a wrongly initializedUnionNode, as was discussed in #605 . This also required that the functions of theNodetrait areunsafe, but this should not be a breaking API change as that trait is never exported from thepoolmodule