-
Notifications
You must be signed in to change notification settings - Fork 8
Fix which sections of binary belong to Flash/ROM vs RAM #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Supporting information for my fix is here https://docs.rs/cortex-m-rt/latest/cortex_m_rt/#sections-size Notice that —besides the mistake— as the text is written, it is unclear why the sum is 2008, since it is nowhere said that `vector_table` belongs to flash at least in this chip. I don't link it because it may break in the future; but I could include it I you want it.
BartMassey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"In these examples the program will…" → "In this example the uploaded software will…"
I think it's confusing to show a .text size and then say that the program occupies more flash than that. Maybe this is better?
|
Thanks for the review. Just to be clear the main issue is that
Not sure what you mean by "this" in. "Maybe this is better"? text is used for the sum, Not sure that is confusing either. Comment: In the page https://github.com/rust-embedded/ it says:
Notice that the link is broken (goes to non-existent page.) |
BartMassey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
|
Yeah, I understood that the sections were wrong. Thanks much for both fixes. The link that you reference is probably broken because the Rust Project is in the process of figuring out what to do with Working Groups. Please file an issue against the |
You are welcome.
Done. |
|
Sigh. CI for this repo seems to be borked somehow. I think I went ahead and merged the commit. Thanks much for your contribution. |
Can not find much except that
I realised that |
|
It's fine. I fixed the CI and will get the missing dot. Thanks much! |
Supporting information for my fix is here https://docs.rs/cortex-m-rt/latest/cortex_m_rt/#sections-size
.datadoes not belong to Flashvector_tabledoes belong to Flash —in this arch at least (see link above).You don't get 2008 bytes otherwise, but now it does add up to 2008.
cc: @adamgreig since it's last person working in this repo.