fix(#172): add regressive tests for preventing OUT_DIR escape for '..' file paths #1631
+89
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodyXu
requested changes
Dec 17, 2025
Contributor
NobodyXu
left a comment
NobodyXu
left a comment
There was a problem hiding this comment.
Thank you, but I have some questions on the PR
Restore ParentDir check lost in rust-lang#931 refactoring. Paths with '..' now hashed to stay within OUT_DIR. - src/command_helpers: re-add Component::ParentDir check - tests: 3 new regression tests
naoNao89
force-pushed
the
fix/issue-172-parent-dir-regression
branch
from
0ce5a50 to
9afb903
Compare
NobodyXu
approved these changes
Dec 17, 2025
Contributor
NobodyXu
left a comment
NobodyXu
left a comment
There was a problem hiding this comment.
Thanks! Adding more regressive tests to prevent bugs is always welcomed!
I'll rename the PR title to reflect that though
NobodyXu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The safety check from #786 got accidentally removed during #931's refactor. This brings it back paths with
..now use hashed names to stay contained.Added 3 regression tests.
Fixes: #172