Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the license for the LLVM code, build script and other files included in the tarballs from
llvm-mingwproject use ISC license: https://github.com/mstorsjo/llvm-mingw/blob/master/LICENSE.txtHow should we handle that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I would ask Wesley/David for the licensing part.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully they won't mind summoning them here.
@wesleywiser @davidtwco can you help us here?
Thinking more about it, llvm-mingw consists of: prebuilt LLVM binaries + headers, prebuilt mingw-w64 + headers, prebuilt dependencies of LLVM like libffi, prebuilt binaries from llvm-mingw repo + shell scripts + Clang config files (they are located here: https://github.com/mstorsjo/llvm-mingw/tree/466fbcb68f024758c20cbea9544a44d1e5194bdc/wrappers), and apparently now it also includes prebuilt Python.
llvm-mingw's
LICENSE.txtstates:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the license of the artifact is Apache 2 w/ LLVM exceptions then I expect this would be fine.