Add new rename-from field to ensure checks when source URL file differs from name
#22
+130
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Nov 16, 2025
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
Looks great, thanks. Left one comment + could you please document the new field in the README?
GuillaumeGomez
force-pushed
the
rename-from
branch
from
ebe18f8 to
0a27fc9
Compare
…iffers from `name`
GuillaumeGomez
force-pushed
the
rename-from
branch
from
0a27fc9 to
b19bba2
Compare
Member
Author
|
Added the new check (and moved the common error code output into an inner function) and added the new field description to the README file. |
Kobzol
previously approved these changes
Nov 17, 2025
GuillaumeGomez
force-pushed
the
rename-from
branch
from
b19bba2 to
b08da67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to avoid situations like #17 / #18 to happen again as discussed on zulip.
cc @Kobzol @marcoieni