qurt: Add support for Qualcomm QuRT #4845

androm3da · 2025-11-21T19:53:04Z

The QuRT RTOS -- used primarily on the Hexagon architecture -- has support for large parts of POSIX.

Description

Add support for Hexagon QuRT OS.

Sources

The corresponding sources from the Hexagon SDK from https://github.com/snapdragon-toolchain/hexagon-sdk or https://softwarecenter.qualcomm.com/catalog/item/Hexagon_SDK

Checklist

N/A - Relevant tests in libc-test/semver have been updated
No placeholder or unstable values like *LAST or *MAX are
included (see #3131)
Tested locally (cd libc-test && cargo test --target mytarget);
especially relevant for platforms that may not be checked in CI

tgross35

You will need to update

libc/build.rs

Lines 33 to 49 in a3bb40e

    
           // Extra values to allow for check-cfg. 
        
           const CHECK_CFG_EXTRA: &[(&str, &[&str])] = &[ 
        
               ( 
        
                   "target_os", 
        
                   &[ 
        
                       "switch", "aix", "ohos", "hurd", "rtems", "visionos", "nuttx", "cygwin", 
        
                   ], 
        
               ), 
        
               ( 
        
                   "target_env", 
        
                   &["illumos", "wasi", "aix", "ohos", "nto71_iosock", "nto80"], 
        
               ), 
        
               ( 
        
                   "target_arch", 
        
                   &["loongarch64", "mips32r6", "mips64r6", "csky"], 
        
               ), 
        
           ];

to make check-cfg work, since this target is only on nightly so far.

tgross35 · 2025-11-30T07:22:10Z

src/new/qurt/mod.rs

+pub(crate) mod errno;
+pub(crate) mod fcntl;
+pub(crate) mod limits;
+pub(crate) mod pthread;
+pub(crate) mod semaphore;
+pub(crate) mod signal;
+pub(crate) mod stdio;
+pub(crate) mod stdlib;
+pub(crate) mod sys;
+pub(crate) mod time;
+pub(crate) mod unistd;


I assume this needs to be filled in right? Or deleted.

I'd appreciate if you could at least make unistd.rs and pthread.rs in src/new roughly matching their .h files, since I've ported most other platforms at this point. Everything else is up to you; you can either add the modules like you have here (eventually everything will hopefully be like this) or just put it all in src/qurt like most other platforms (and I'll move them over later).

tgross35 · 2025-11-30T07:22:21Z

src/new/qurt/mod.rs

+//! QuRT (Qualcomm Real-Time OS) bindings
+//!
+//! QuRT is Qualcomm's real-time operating system for Hexagon DSP architectures.


Mind adding a link to the SDK sources?

Here, in the PR comments or in the comments of src/new/qurt/mod.rs?

The doc comment - I've been doing this for src/new to give some breadcrumbs for anyone who wants to check / update things.

rustbot · 2025-11-30T07:26:19Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

androm3da · 2025-12-08T19:42:38Z

AFAICT this failure is not related to my changes - I wonder if it's the kind of thing that might get addressed by a rebase? Or just re-running it?

Maybe this is something that #4872 was intended to fix? Or on the flip side, introduced by #4872?

+ cargo test --target x86_64-unknown-freebsd --workspace --no-default-features -- --skip check_style
    Updating crates.io index
error: failed to get `askama` as a dependency of package `ctest v0.5.0-beta.1 (/tmp/cirrus-ci-build/ctest)`

Caused by:
  download of config.json failed

Caused by:
  failed to download from `https://index.crates.io/config.json`

Caused by:
  [60] SSL peer certificate or SSH remote key was not OK (SSL certificate OpenSSL verify result: unable to get local issuer certificate (20))

Exit status: 101

androm3da · 2025-12-09T14:36:10Z

@rustbot ready

tgross35 · 2025-12-17T07:30:00Z

src/qurt/mod.rs

It looks like a lot of the defs in this file are duplicated between src/qurt and src/new/qurt, don't they need to be dropped?

Other than this, LGTM.

Sorry: I have removed these duplicates now.

tgross35 · 2025-12-17T07:31:21Z

Also if you could squash any commits that have back-and-forth (e.g. adding src/qurt then later removing it) that would be helpful, makes backporting cleaner.

The QuRT RTOS -- used primarily on the Hexagon architecture -- has support for large parts of POSIX.

rustbot · 2025-12-17T18:14:47Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

androm3da · 2025-12-17T18:16:12Z

Also if you could squash any commits that have back-and-forth (e.g. adding src/qurt then later removing it) that would be helpful, makes backporting cleaner.

I assumed that I would squash them all before merging? I have squashed all but the most recent changes now.

tgross35 · 2025-12-18T08:06:11Z

src/qurt/mod.rs

+    pub fn floor(x: c_double) -> c_double;
+    pub fn floorf(x: c_float) -> c_float;
+    pub fn fmod(x: c_double, y: c_double) -> c_double;
+    pub fn fmodf(x: c_float, y: c_float) -> c_float;


Noticed one other thing: we don't provide bindings for the math functions in libc, std binds them as necessary for the platform.

rustbot added the S-waiting-on-review label Nov 21, 2025

tgross35 requested changes Nov 30, 2025

View reviewed changes

rustbot added S-waiting-on-author and removed S-waiting-on-review labels Nov 30, 2025

androm3da force-pushed the bcain/qurt branch from a4b6dcf to 932ba01 Compare December 7, 2025 05:17

rustbot added S-waiting-on-review and removed S-waiting-on-author labels Dec 9, 2025

androm3da force-pushed the bcain/qurt branch from 932ba01 to aec4b56 Compare December 15, 2025 13:39

This comment has been minimized.

Sign in to view

tgross35 requested changes Dec 17, 2025

View reviewed changes

rustbot added S-waiting-on-author and removed S-waiting-on-review labels Dec 17, 2025

androm3da added 2 commits December 17, 2025 12:13

qurt: Add support for Qualcomm QuRT

f6894a4

The QuRT RTOS -- used primarily on the Hexagon architecture -- has support for large parts of POSIX.

Remove duplicate definitions between qurt src/new/qurt

7035a87

androm3da force-pushed the bcain/qurt branch from aec4b56 to 7035a87 Compare December 17, 2025 18:14

tgross35 reviewed Dec 18, 2025

View reviewed changes

Remove math func declarations

00d65a0

	// Extra values to allow for check-cfg.
	const CHECK_CFG_EXTRA: &[(&str, &[&str])] = &[
	(
	"target_os",
	&[
	"switch", "aix", "ohos", "hurd", "rtems", "visionos", "nuttx", "cygwin",
	],
	),
	(
	"target_env",
	&["illumos", "wasi", "aix", "ohos", "nto71_iosock", "nto80"],
	),
	(
	"target_arch",
	&["loongarch64", "mips32r6", "mips64r6", "csky"],
	),
	];

qurt: Add support for Qualcomm QuRT #4845

Are you sure you want to change the base?

qurt: Add support for Qualcomm QuRT #4845

Uh oh!

Conversation

androm3da commented Nov 21, 2025

Description

Sources

Checklist

Uh oh!

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented Nov 30, 2025

Uh oh!

androm3da commented Dec 8, 2025

Uh oh!

androm3da commented Dec 9, 2025

Uh oh!

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgross35 commented Dec 17, 2025

Uh oh!

rustbot commented Dec 17, 2025

Uh oh!

androm3da commented Dec 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants