Skip to content

Fix empty_enum_variants_with_brackets misses removing brackets in patterns #16160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samueltardieu merged 2 commits into from
Dec 16, 2025
Merged

Fix empty_enum_variants_with_brackets misses removing brackets in patterns #16160

samueltardieu merged 2 commits into from
Dec 16, 2025
+297 −90

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Nov 30, 2025 •
edited by rustbot
Loading

Closes #16157

changelog: [empty_enum_variants_with_brackets] fix missing to remove brackets in patterns

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ada4a
ada4a suggested changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@ada4a ada4a left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this:) Some small suggestions

View changes since this review

@github-actions
Copy link

github-actions bot commented Dec 1, 2025 •
edited
Loading

Lintcheck changes for 9642358

Lint Added Removed Changed
clippy::empty_enum_variants_with_brackets 0 1 0

This comment will be updated if you push new changes

gauravagerwala added a commit to gauravagerwala/rust-clippy that referenced this pull request Dec 7, 2025
@gauravagerwala
Update design for PR rust-lang#16160: Fix `empty_enum_variants_with_b…
f9ac621 
…rackets` misses removing brackets in patterns
samueltardieu
samueltardieu requested changes Dec 15, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lintcheck here shows that brackets may sometimes be used on purpose, for example when there is a comment. Could you please add a check that there is no non-whitespace (including comments) inside the brackets, and the corresponding tests (for example with a comment, and with a #[cfg]-d out field)? That would be an improvement.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Dec 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@profetia
Copy link
Contributor Author

profetia commented Dec 15, 2025

Added. Thank you!

samueltardieu
samueltardieu requested changes Dec 16, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Dec 16, 2025
samueltardieu
samueltardieu requested changes Dec 16, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last nit and we should be good to go.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Dec 16, 2025
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Dec 16, 2025
@samueltardieu samueltardieu added this pull request to the merge queue Dec 16, 2025
Merged via the queue into rust-lang:master with commit 020c7cf Dec 16, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

+1 more reviewer

@ada4a ada4a ada4a requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samueltardieu samueltardieu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

empty-enum-variants-with-brackets breaks code: expected tuple struct or tuple variant, found unit variant

4 participants

@profetia @rustbot @samueltardieu @ada4a