Skip to content

Fix unchecked_time_subtraction FN on Ops::sub method call #16233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jarcho merged 3 commits into from
Dec 13, 2025
Merged

Fix unchecked_time_subtraction FN on Ops::sub method call #16233

Jarcho merged 3 commits into from
Dec 13, 2025

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Dec 13, 2025 •
edited by rustbot
Loading

Closes #16230
Closes #16234
Closes #16236

changelog: [unchecked_time_subtraction] fix FN on Ops::sub method call

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@profetia
Copy link
Contributor Author

profetia commented Dec 13, 2025

Also closes #16234

Jarcho
Jarcho requested changes Dec 13, 2025
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few minor things.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Dec 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@profetia
Copy link
Contributor Author

profetia commented Dec 13, 2025

Looks tthe manual_instant_elapsed covered here also has unmangling issues. Will get it fixed too.

@profetia profetia requested a review from Jarcho December 13, 2025 20:59
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Dec 13, 2025
Jarcho
Jarcho approved these changes Dec 13, 2025
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

View changes since this review

@Jarcho Jarcho added this pull request to the merge queue Dec 13, 2025
Merged via the queue into rust-lang:master with commit 9a089b6 Dec 13, 2025
13 of 15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jarcho Jarcho Jarcho approved these changes

Assignees

@Jarcho Jarcho

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@profetia @rustbot @Jarcho