Skip to content

Unquerify extern_mod_stmt_cnum. #143374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

Unquerify extern_mod_stmt_cnum. #143374

merged 1 commit into from
Jul 24, 2025

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jul 3, 2025

Based on #143247
r? @ghost for perf

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 3, 2025
@petrochenkov petrochenkov self-assigned this Jul 4, 2025
@petrochenkov petrochenkov added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 4, 2025
@cjgillot cjgillot force-pushed the bare-extern-crate-map branch from e77bf48 to b232992 Compare July 4, 2025 14:01
@cjgillot
Copy link
Contributor Author

cjgillot commented Jul 4, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 4, 2025
bors added a commit that referenced this pull request Jul 4, 2025
@bors
Auto merge of #143374 - cjgillot:bare-extern-crate-map, r=<try>
660c02e 
Unquerify extern_mod_stmt_cnum.

Based on #143247
r? `@ghost` for perf
@bors
Copy link
Collaborator

bors commented Jul 4, 2025

⌛ Trying commit b232992 with merge 660c02e...

@bors
Copy link
Collaborator

bors commented Jul 4, 2025

☀️ Try build successful - checks-actions
Build commit: 660c02e (660c02eca56a74273f10f02ca1eeb7df1b10633f)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (660c02e): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.3% [0.2%, 0.4%] 4
Regressions ❌
(secondary)		 1.0% [1.0%, 1.0%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.9% [-0.9%, -0.9%] 2
All ❌✅ (primary) 0.3% [0.2%, 0.4%] 4

Max RSS (memory usage)

Results (primary -1.0%, secondary -4.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.4% [1.4%, 1.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.2% [-2.7%, -1.7%] 2
Improvements ✅
(secondary)		 -4.0% [-6.9%, -0.5%] 5
All ❌✅ (primary) -1.0% [-2.7%, 1.4%] 3

Cycles

Results (secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.0% [3.5%, 5.0%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.0% [-5.0%, -2.0%] 5
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 461.146s -> 460.016s (-0.25%)
Artifact size: 372.20 MiB -> 372.17 MiB (-0.01%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 4, 2025
@cjgillot cjgillot force-pushed the bare-extern-crate-map branch from b232992 to ad2b0f8 Compare July 20, 2025 13:26
@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2025
@petrochenkov petrochenkov marked this pull request as ready for review July 21, 2025 14:54
@rustbot
Copy link
Collaborator

rustbot commented Jul 21, 2025

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

@petrochenkov
Copy link
Contributor

This is a simplification and the perf diff seems to be noise.
r=me unless you want to do something else with this (the PR was never marked as waiting on review).
@bors rollup=maybe
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 21, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@cjgillot
Copy link
Contributor Author

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Jul 22, 2025

📌 Commit ad2b0f8 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 22, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#143374 - cjgillot:bare-extern-crate-map, r=…
08aaa14 
…petrochenkov

Unquerify extern_mod_stmt_cnum.

Based on rust-lang#143247
r? `@ghost` for perf
This was referenced Jul 22, 2025
Closed
Closed
@bors
Copy link
Collaborator

bors commented Jul 22, 2025

☔ The latest upstream changes (presumably #144294) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 22, 2025
@cjgillot cjgillot force-pushed the bare-extern-crate-map branch from ad2b0f8 to 3440bc9 Compare July 22, 2025 22:39
@cjgillot
Copy link
Contributor Author

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Jul 22, 2025

📌 Commit 3440bc9 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2025
fmease added a commit to fmease/rust that referenced this pull request Jul 23, 2025
@fmease
Rollup merge of rust-lang#143374 - cjgillot:bare-extern-crate-map, r=…
aab76e7 
…petrochenkov

Unquerify extern_mod_stmt_cnum.

Based on rust-lang#143247
r? `@ghost` for perf
@fmease fmease mentioned this pull request Jul 23, 2025
Closed
fmease added a commit to fmease/rust that referenced this pull request Jul 23, 2025
@fmease
Rollup merge of rust-lang#143374 - cjgillot:bare-extern-crate-map, r=…
8469ec1 
…petrochenkov

Unquerify extern_mod_stmt_cnum.

Based on rust-lang#143247
r? ``@ghost`` for perf
@fmease fmease mentioned this pull request Jul 23, 2025
Closed
fmease added a commit to fmease/rust that referenced this pull request Jul 24, 2025
@fmease
Rollup merge of rust-lang#143374 - cjgillot:bare-extern-crate-map, r=…
bd914d0 
…petrochenkov

Unquerify extern_mod_stmt_cnum.

Based on rust-lang#143247
r? ```@ghost``` for perf
@fmease fmease mentioned this pull request Jul 24, 2025
Closed
bors added a commit that referenced this pull request Jul 24, 2025
@bors
Auto merge of #144384 - fmease:rollup-fqlje3j, r=fmease
a5f68b3 
Rollup of 15 pull requests

Successful merges:

 - #132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links)
 - #143374 (Unquerify extern_mod_stmt_cnum.)
 - #143838 (std: net: uefi: Add support to query connection data)
 - #144014 (don't link to the nightly version of the Edition Guide in stable lints)
 - #144094 (Ensure we codegen the main fn)
 - #144218 (Use serde for target spec json deserialize)
 - #144221 (generate elf symbol version in raw-dylib)
 - #144240 (Add more test case to check if the false note related to sealed trait suppressed)
 - #144247 (coretests/num: use ldexp instead of hard-coding a power of 2)
 - #144276 (Use less HIR in check_private_in_public.)
 - #144317 (pass build.npm from bootstrap to tidy and use it for npm install)
 - #144320 (rustdoc: avoid allocating a temp String for aliases in search index)
 - #144334 (rustc_resolve: get rid of unused rustdoc::span_of_fragments_with_expansion)
 - #144335 (Don't suggest assoc ty bound on non-angle-bracketed problematic assoc ty binding)
 - #144358 (Stop using the old `validate_attr` logic for stability attributes)

r? `@ghost`
`@rustbot` modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull request Jul 24, 2025
@fmease
Rollup merge of rust-lang#143374 - cjgillot:bare-extern-crate-map, r=…
6f0d38e 
…petrochenkov

Unquerify extern_mod_stmt_cnum.

Based on rust-lang#143247
r? ````@ghost```` for perf
@fmease fmease mentioned this pull request Jul 24, 2025
Closed
bors added a commit that referenced this pull request Jul 24, 2025
@bors
Auto merge of #144387 - fmease:rollup-nh0gn9t, r=fmease
5bcd716 
Rollup of 16 pull requests

Successful merges:

 - #143374 (Unquerify extern_mod_stmt_cnum.)
 - #143838 (std: net: uefi: Add support to query connection data)
 - #144014 (don't link to the nightly version of the Edition Guide in stable lints)
 - #144094 (Ensure we codegen the main fn)
 - #144218 (Use serde for target spec json deserialize)
 - #144221 (generate elf symbol version in raw-dylib)
 - #144232 (Implement support for `become` and explicit tail call codegen for the LLVM backend)
 - #144240 (Add more test case to check if the false note related to sealed trait suppressed)
 - #144247 (coretests/num: use ldexp instead of hard-coding a power of 2)
 - #144276 (Use less HIR in check_private_in_public.)
 - #144278 (add Rev::into_inner)
 - #144317 (pass build.npm from bootstrap to tidy and use it for npm install)
 - #144320 (rustdoc: avoid allocating a temp String for aliases in search index)
 - #144334 (rustc_resolve: get rid of unused rustdoc::span_of_fragments_with_expansion)
 - #144335 (Don't suggest assoc ty bound on non-angle-bracketed problematic assoc ty binding)
 - #144358 (Stop using the old `validate_attr` logic for stability attributes)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request Jul 24, 2025
Merged
bors added a commit that referenced this pull request Jul 24, 2025
@bors
Auto merge of #144398 - fmease:rollup-z6vq7mi, r=fmease
246733a 
Rollup of 15 pull requests

Successful merges:

 - #143374 (Unquerify extern_mod_stmt_cnum.)
 - #143838 (std: net: uefi: Add support to query connection data)
 - #144014 (don't link to the nightly version of the Edition Guide in stable lints)
 - #144094 (Ensure we codegen the main fn)
 - #144218 (Use serde for target spec json deserialize)
 - #144221 (generate elf symbol version in raw-dylib)
 - #144240 (Add more test case to check if the false note related to sealed trait suppressed)
 - #144247 (coretests/num: use ldexp instead of hard-coding a power of 2)
 - #144276 (Use less HIR in check_private_in_public.)
 - #144278 (add Rev::into_inner)
 - #144317 (pass build.npm from bootstrap to tidy and use it for npm install)
 - #144320 (rustdoc: avoid allocating a temp String for aliases in search index)
 - #144334 (rustc_resolve: get rid of unused rustdoc::span_of_fragments_with_expansion)
 - #144335 (Don't suggest assoc ty bound on non-angle-bracketed problematic assoc ty binding)
 - #144358 (Stop using the old `validate_attr` logic for stability attributes)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 404f904 into rust-lang:master Jul 24, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 24, 2025
rust-timer added a commit that referenced this pull request Jul 24, 2025
@rust-timer
Unrolled build for #143374
83a2eb9 
Rollup merge of #143374 - cjgillot:bare-extern-crate-map, r=petrochenkov

Unquerify extern_mod_stmt_cnum.

Based on #143247
r? `````@ghost````` for perf
@cjgillot cjgillot deleted the bare-extern-crate-map branch July 24, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cjgillot @rust-timer @bors @rustbot @petrochenkov