Skip to content

Conversation

workingjubilee
Copy link
Member

@workingjubilee workingjubilee commented Jul 5, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

SciMind2460 and others added 30 commits June 27, 2025 16:26
Prepare for rework done by the rest of RUST-142440.

Co-authored-by: Kivooeo <Kivooeo123@gmail.com>
opeq.rs was removed as duplicating test logic in other tests
`tests/ui`: A New Order [14/N]

> [!NOTE]
>
> Intermediate commits are intended to help review, but will be squashed prior to merge.

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.

r? `@jieyouxu`
Update poison.rs to fix the typo (sys->sync)
`tests/ui`: A New Order [18/N]

> [!NOTE]
>
> Intermediate commits are intended to help review, but will be squashed prior to merge.

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.

r? `@tgross35`
`tests/ui`: A New Order [21/N]

> [!NOTE]
>
> Intermediate commits are intended to help review, but will be squashed prior to merge.

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.

r? `@tgross35`
`tests/ui`: A New Order [22/N]

> [!NOTE]
>
> Intermediate commits are intended to help review, but will be squashed prior to merge.

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.

r? `@tgross35`
`tests/ui`: A New Order [24/N]

> [!NOTE]
>
> Intermediate commits are intended to help review, but will be squashed prior to merge.

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.

r? `@tgross35`
`tests/ui`: A New Order [25/N]

> [!NOTE]
>
> Intermediate commits are intended to help review, but will be squashed prior to merge.

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.

r? `@tgross35`
…-rust-to-c, r=RalfJung

test passing a `VaList` from rust to C

Have C define various functions that take a `...` or `va_list` as an argument, and call them from rust. As far as I can see, this just wasn't actually tested before.

In particular this tests a difference between rust `VaList` and C `va_list` where C uses array-to-pointer decay, but rust cannot.

I've locally tested this for

- `x86_64-unknown-linux-gnu`
- `aarch64-unknown-linux-gnu`
- `s390x-unknown-linux-gnu`
- `powerpc64-unknown-linux-gnu`
- `powerpc64le-unknown-linux-gnu`

The latter 2 use an opaque pointer, the first 3 use a single-element array.

cc `@beetrees` if you see anything incorrect here

r? `@workingjubilee`
…alfJung,workingjubilee

Block SIMD in transmute_immediate; delete `OperandValueKind`

Vectors have been causing me problems for years in this code, for example rust-lang#110021 (comment) and rust-lang#143194

See conversation in <https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Is.20transmuting.20a.20.60T.60.20to.20.60Tx1.60.20.28one-element.20SIMD.20vector.29.20UB.3F/near/526262799>.

By blocking SIMD in `transmute_immediate` it can be simplified to just take the `Scalar`s involved -- the backend types can be gotten from those `Scalar`s, rather than needing to be passed.  And there's an assert added to ICE it if it does get hit.

Accordingly, this changes `rvalue_creates_operand` to not send SIMD transmutes through the operand path, but to always go through memory instead, like they did back before rust-lang#108442.

And thanks to those changes, I could also remove the `OperandValueKind` type that I added back then which `@RalfJung` rightly considers pretty sketchy.

cc `@folkertdev` `@workingjubilee` from the zulip conversation too
Fix CLI completion check in `tidy`

The list of CLI completion files that were generated and that were checked by `x test tidy` was not synced. Recently, some PR only updated some of the files, which caused the rest of the files (not checked by `x test tidy`) to be dirty on `master`. This PR fixes the logic in bootstrap to always synchronize the list of completion paths.

Fixes: rust-lang#143451

r? `@jieyouxu`
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jul 5, 2025
@workingjubilee
Copy link
Member Author

@bors rollup=never p=5

@scottmcm
Copy link
Member

scottmcm commented Jul 5, 2025

This wasn't previously approved, but since it passed the PR checks,
@bors r+

@bors
Copy link
Collaborator

bors commented Jul 5, 2025

📌 Commit 77ae270 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2025
@bors
Copy link
Collaborator

bors commented Jul 5, 2025

⌛ Testing commit 77ae270 with merge fd9ca71...

@bors
Copy link
Collaborator

bors commented Jul 5, 2025

☀️ Test successful - checks-actions
Approved by: scottmcm
Pushing fd9ca71 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 5, 2025
@bors bors merged commit fd9ca71 into rust-lang:master Jul 5, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 5, 2025
Copy link
Contributor

github-actions bot commented Jul 5, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f0b67dd (parent) -> fd9ca71 (this PR)

Test differences

Show 242 test diffs

Stage 1

  • [ui] tests/ui/cfg/nested-cfg-attr-conditional-compilation.rs: [missing] -> pass (J0)
  • [ui] tests/ui/closures/closure-last-use-move.rs: [missing] -> pass (J0)
  • [ui] tests/ui/closures/closure-upvar-last-use-analysis.rs: [missing] -> pass (J0)
  • [ui] tests/ui/closures/many-closures.rs: [missing] -> pass (J0)
  • [ui] tests/ui/coercion/basic-ptr-coercions.rs: [missing] -> pass (J0)
  • [ui] tests/ui/cross-crate/cross-crate-refcell-match.rs: [missing] -> pass (J0)
  • [ui] tests/ui/cross-crate/metadata-trait-serialization.rs: [missing] -> pass (J0)
  • [ui] tests/ui/fn/mutable-function-parameters.rs: [missing] -> pass (J0)
  • [ui] tests/ui/io-checks/io-stdout-blocking-writes.rs: [missing] -> pass (J0)
  • [ui] tests/ui/issue-15924.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issue-16822.rs: pass -> [missing] (J0)
  • [ui] tests/ui/kinds-in-metadata.rs: pass -> [missing] (J0)
  • [ui] tests/ui/last-use-in-block.rs: pass -> [missing] (J0)
  • [ui] tests/ui/modules/mod-same-item-names.rs: [missing] -> pass (J0)
  • [ui] tests/ui/mutual-recursion-group.rs: pass -> [missing] (J0)
  • [ui] tests/ui/nested-block-comment.rs: pass -> [missing] (J0)
  • [ui] tests/ui/nested-cfg-attrs.rs: pass -> [missing] (J0)
  • [ui] tests/ui/nested-ty-params.rs: pass -> [missing] (J0)
  • [ui] tests/ui/not-enough-arguments.rs: pass -> [missing] (J0)
  • [ui] tests/ui/nullable-pointer-iotareduction.rs: pass -> [missing] (J0)
  • [ui] tests/ui/objects-coerce-freeze-borrored.rs: pass -> [missing] (J0)
  • [ui] tests/ui/occurs-check-2.rs: pass -> [missing] (J0)
  • [ui] tests/ui/occurs-check-3.rs: pass -> [missing] (J0)
  • [ui] tests/ui/oom_unwind.rs: pass -> [missing] (J0)
  • [ui] tests/ui/opeq.rs: pass -> [missing] (J0)
  • [ui] tests/ui/parser/doc-comment-in-generic.rs: [missing] -> pass (J0)
  • [ui] tests/ui/point-to-type-err-cause-on-impl-trait-return-2.rs: pass -> [missing] (J0)
  • [ui] tests/ui/pptypedef.rs: pass -> [missing] (J0)
  • [ui] tests/ui/primitive-binop-lhs-mut.rs: pass -> [missing] (J0)
  • [ui] tests/ui/project-cache-issue-31849.rs: pass -> [missing] (J0)
  • [ui] tests/ui/ptr-coercion-rpass.rs: pass -> [missing] (J0)
  • [ui] tests/ui/raw-str.rs: pass -> [missing] (J0)
  • [ui] tests/ui/realloc-16687.rs: pass -> [missing] (J0)
  • [ui] tests/ui/reassign-ref-mut.rs: pass -> [missing] (J0)
  • [ui] tests/ui/reexport-test-harness-main.rs: pass -> [missing] (J0)
  • [ui] tests/ui/resolve/resolve-same-name-struct.rs: [missing] -> pass (J0)
  • [ui] tests/ui/resource-destruct.rs: pass -> [missing] (J0)
  • [ui] tests/ui/sized-cycle-note.rs: pass -> [missing] (J0)
  • [ui] tests/ui/sized-owned-pointer.rs: pass -> [missing] (J0)
  • [ui] tests/ui/std-uncopyable-atomics.rs: pass -> [missing] (J0)
  • [ui] tests/ui/stdio-is-blocking.rs: pass -> [missing] (J0)
  • [ui] tests/ui/str/nul-char-equivalence.rs: [missing] -> pass (J0)
  • [ui] tests/ui/string-box-error.rs: pass -> [missing] (J0)
  • [ui] tests/ui/sync/atomic-types-not-copyable.rs: [missing] -> pass (J0)
  • [ui] tests/ui/traits/copy-requires-all-fields-copy.rs: [missing] -> pass (J0)
  • [ui] tests/ui/traits/error-trait-object-from-string.rs: [missing] -> pass (J0)
  • [ui] tests/ui/type-inference/direct-self-reference-occurs-check.rs: [missing] -> pass (J0)
  • [ui] tests/ui/type-inference/enum-self-reference-occurs-check.rs: [missing] -> pass (J0)
  • [ui] tests/ui/type-inference/infinite-type-occurs-check.rs: [missing] -> pass (J0)
  • [ui] tests/ui/type/mutually-recursive-types.rs: [missing] -> pass (J0)

Stage 2

  • [ui] tests/ui/allocator/alloc-shrink-oob-read.rs: [missing] -> pass (J1)
  • [ui] tests/ui/async-await/impl-future-escaping-bound-vars-ice.rs: [missing] -> pass (J1)
  • [ui] tests/ui/closures/closure-upvar-last-use-analysis.rs: [missing] -> pass (J1)
  • [ui] tests/ui/coercion/ptr-mutability-errors.rs: [missing] -> pass (J1)
  • [ui] tests/ui/cross-crate/metadata-trait-serialization.rs: [missing] -> pass (J1)
  • [ui] tests/ui/diagnostic-flags/error-format-short.rs: [missing] -> pass (J1)
  • [ui] tests/ui/drop/drop-once-on-move.rs: [missing] -> pass (J1)
  • [ui] tests/ui/drop/drop-scope-exit.rs: [missing] -> pass (J1)
  • [ui] tests/ui/fn/fn-arg-count-mismatch-diagnostics.rs: [missing] -> pass (J1)
  • [ui] tests/ui/generics/trait-incorrect-generic-args.rs: [missing] -> pass (J1)
  • [ui] tests/ui/io-checks/io-stdout-blocking-writes.rs: [missing] -> pass (J1)
  • [ui] tests/ui/issue-16822.rs: pass -> [missing] (J1)
  • [ui] tests/ui/kinds-of-primitive-impl.rs: pass -> [missing] (J1)
  • [ui] tests/ui/last-use-in-block.rs: pass -> [missing] (J1)
  • [ui] tests/ui/layout/null-pointer-optimization-sizes.rs: [missing] -> pass (J1)
  • [ui] tests/ui/mismatched_types/closure-parameter-type-inference-mismatch.rs: [missing] -> pass (J1)
  • [ui] tests/ui/mismatched_types/type-error-diagnostic-in-complex-return.rs: [missing] -> pass (J1)
  • [ui] tests/ui/mut-function-arguments.rs: pass -> [missing] (J1)
  • [ui] tests/ui/mutual-recursion-group.rs: pass -> [missing] (J1)
  • [ui] tests/ui/myriad-closures.rs: pass -> [missing] (J1)
  • [ui] tests/ui/nul-characters.rs: pass -> [missing] (J1)
  • [ui] tests/ui/occurs-check-3.rs: pass -> [missing] (J1)
  • [ui] tests/ui/once-cant-call-twice-on-heap.rs: pass -> [missing] (J1)
  • [ui] tests/ui/opeq.rs: pass -> [missing] (J1)
  • [ui] tests/ui/opt-in-copy.rs: pass -> [missing] (J1)
  • [ui] tests/ui/parser/nested-block-comments.rs: [missing] -> pass (J1)
  • [ui] tests/ui/parser/raw/raw-string-literals.rs: [missing] -> pass (J1)
  • [ui] tests/ui/paths-containing-nul.rs: pass -> [missing] (J1)
  • [ui] tests/ui/ptr-coercion.rs: pass -> [missing] (J1)
  • [ui] tests/ui/query-visibility.rs: pass -> [missing] (J1)
  • [ui] tests/ui/realloc-16687.rs: pass -> [missing] (J1)
  • [ui] tests/ui/reassign-ref-mut.rs: pass -> [missing] (J1)
  • [ui] tests/ui/reexport-test-harness-main.rs: pass -> [missing] (J1)
  • [ui] tests/ui/resolve/resolve-same-name-struct.rs: [missing] -> pass (J1)
  • [ui] tests/ui/seq-args.rs: pass -> [missing] (J1)
  • [ui] tests/ui/sized-owned-pointer.rs: pass -> [missing] (J1)
  • [ui] tests/ui/sized/sized-reference-to-unsized.rs: [missing] -> pass (J1)
  • [ui] tests/ui/sse2.rs: pass -> [missing] (J1)
  • [ui] tests/ui/std-uncopyable-atomics.rs: pass -> [missing] (J1)
  • [ui] tests/ui/str/nul-char-equivalence.rs: [missing] -> pass (J1)
  • [ui] tests/ui/string-box-error.rs: pass -> [missing] (J1)
  • [ui] tests/ui/sync/atomic-types-not-copyable.rs: [missing] -> pass (J1)
  • [ui] tests/ui/target-feature/target-feature-detection.rs: [missing] -> pass (J1)
  • [ui] tests/ui/traits/error-trait-object-from-string.rs: [missing] -> pass (J1)
  • [ui] tests/ui/traits/trait-object-method-receiver-rules.rs: [missing] -> pass (J1)
  • [ui] tests/ui/type-inference/direct-self-reference-occurs-check.rs: [missing] -> pass (J1)
  • [ui] tests/ui/type-inference/infinite-type-occurs-check.rs: [missing] -> pass (J1)
  • [ui] tests/ui/type/inherent-impl-primitive-types-error.rs: [missing] -> pass (J1)
  • [ui] tests/ui/type/mutually-recursive-types.rs: [missing] -> pass (J1)
  • [ui] tests/ui/panics/oom-panic-unwind.rs: [missing] -> pass (J2)

(and 140 additional test diffs)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard fd9ca711a3a0e2bd5bd33a345fa4439348111006 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 4942.2s -> 3402.2s (-31.2%)
  2. dist-x86_64-apple: 7246.5s -> 8971.3s (23.8%)
  3. dist-apple-various: 5874.7s -> 7127.3s (21.3%)
  4. aarch64-apple: 5254.6s -> 4334.0s (-17.5%)
  5. pr-check-1: 1830.7s -> 1581.9s (-13.6%)
  6. aarch64-gnu-debug: 4164.3s -> 3645.6s (-12.5%)
  7. dist-aarch64-apple: 4806.6s -> 5369.6s (11.7%)
  8. x86_64-gnu-tools: 3562.3s -> 3231.7s (-9.3%)
  9. x86_64-gnu-debug: 5845.0s -> 5307.2s (-9.2%)
  10. x86_64-gnu-aux: 6558.9s -> 5968.5s (-9.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#142440 tests/ui: A New Order [14/N] df909951e9830b2dbc1bc4733f28b833bd2c7d1c (link)
#143040 Add const Rem 6183aad0b156f92ecd383c33032078b90c9d94fc (link)
#143086 Update poison.rs to fix the typo (sys->sync) ff646ba0abfbc444f9b75a4bbf6bb984004fd9a8 (link)
#143202 tests/ui: A New Order [18/N] 1121e704492a0301d9d395f0c4a82f0717a118e6 (link)
#143296 tests/ui: A New Order [21/N] b879b6e9e0271d7887f4d5cbce5f2ae2f2dd2fc5 (link)
#143297 tests/ui: A New Order [22/N] 0bd9b5c8ad867314bf4445340eecd0b623a1fb93 (link)
#143299 tests/ui: A New Order [24/N] ec414cfe3155a40f89eefef511a0d1ead066250f (link)
#143300 tests/ui: A New Order [25/N] 3866b84b901ebce6726e81d1c55d5e5ebc6ebf7d (link)
#143397 test passing a VaList from rust to C 47ff0b0387adfc898f738aad358f7764c160ebc9 (link)
#143410 Block SIMD in transmute_immediate; delete OperandValueKind 8ed3690b848ec0a2dcb5f68e9c5dfc1050670b18 (link)
#143452 Fix CLI completion check in tidy ed634c8dc735d2241df14b53ac74800f0b386f43 (link)

previous master: f0b67dd97d

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fd9ca71): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 2
Improvements ✅
(primary)
-2.9% [-2.9%, -2.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.9% [-2.9%, -2.9%] 1

Max RSS (memory usage)

Results (primary -2.9%, secondary -1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.3% [3.3%, 3.3%] 1
Improvements ✅
(primary)
-2.9% [-2.9%, -2.9%] 1
Improvements ✅
(secondary)
-4.2% [-4.8%, -3.6%] 2
All ❌✅ (primary) -2.9% [-2.9%, -2.9%] 1

Cycles

Results (secondary 0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.1% [0.5%, 6.1%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.3% [-4.2%, -0.5%] 4
All ❌✅ (primary) - - 0

Binary size

Results (primary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 1

Bootstrap: 460.935s -> 458.797s (-0.46%)
Artifact size: 372.19 MiB -> 372.11 MiB (-0.02%)

@workingjubilee workingjubilee deleted the rollup-bxie7zg branch July 7, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants