miri: for ABI mismatch errors, say which argument is the problem #144535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
requested changes
Jul 27, 2025
Comment on lines
132
to
136
| calling a function whose {$arg_idx -> | ||
| [1] 1st | ||
| [2] 2nd | ||
| *[other] {$arg_idx}th | ||
| } parameter has type {$callee_ty} passing argument of type {$caller_ty} |
There was a problem hiding this comment.
Could you rephrase this so we don't use an ordinal (1st/2nd/3rd/4th)? I think it's fine to just say "argument #n" or something.
AFAICT right now it's not right for 3 (3rd) or any other numbers that end in 1/2/3.
There was a problem hiding this comment.
AFAICT right now it's not right for 3 (3rd)
Ah damn... yeah English makes this mighty annoying.
|
Otherwise r=me after fixing the phrasing. |
rustbot
added
S-waiting-on-author
RalfJung
force-pushed
the
abi-mismatch-err
branch
from
51fea05 to
296586f
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 27, 2025
…ler-errors miri: for ABI mismatch errors, say which argument is the problem
bors
added a commit
that referenced
this pull request
Jul 27, 2025
Rollup of 7 pull requests Successful merges: - #143289 (Remove `[T]::array_chunks(_mut)`) - #143607 (Port the proc macro attributes to the new attribute parsing infrastructure) - #144471 (Remove `compiler-builtins-{no-asm,mangled-names}`) - #144495 (bump cargo_metadata) - #144523 (rustdoc: save target modifiers) - #144534 (check_static_item: explain should_check_for_sync choices) - #144535 (miri: for ABI mismatch errors, say which argument is the problem) Failed merges: - #144536 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jul 28, 2025
Rollup of 6 pull requests Successful merges: - #143607 (Port the proc macro attributes to the new attribute parsing infrastructure) - #144471 (Remove `compiler-builtins-{no-asm,mangled-names}`) - #144495 (bump cargo_metadata) - #144523 (rustdoc: save target modifiers) - #144534 (check_static_item: explain should_check_for_sync choices) - #144535 (miri: for ABI mismatch errors, say which argument is the problem) Failed merges: - #144536 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 28, 2025
Rollup merge of #144535 - RalfJung:abi-mismatch-err, r=compiler-errors miri: for ABI mismatch errors, say which argument is the problem
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Jul 28, 2025
Rollup of 6 pull requests Successful merges: - rust-lang/rust#143607 (Port the proc macro attributes to the new attribute parsing infrastructure) - rust-lang/rust#144471 (Remove `compiler-builtins-{no-asm,mangled-names}`) - rust-lang/rust#144495 (bump cargo_metadata) - rust-lang/rust#144523 (rustdoc: save target modifiers) - rust-lang/rust#144534 (check_static_item: explain should_check_for_sync choices) - rust-lang/rust#144535 (miri: for ABI mismatch errors, say which argument is the problem) Failed merges: - rust-lang/rust#144536 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.