Skip to content

Start reporting future breakage for ILL_FORMED_ATTRIBUTE_INPUT in dependencies #144544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Start reporting future breakage for ILL_FORMED_ATTRIBUTE_INPUT in dependencies #144544

wants to merge 1 commit into from
+177 −0

Conversation

JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Jul 27, 2025 •
edited
Loading

This has been a warn lint since early 2019 and a deny-by-default lint since late 2019.
We're currently transitioning some of the cases where this lint is being produced to a hard error (#143607 #143808 and more)
So let's report this lint in all dependencies for the remaining attributes

r? @traviscross
@rustbot labels +I-lang-nominated +T-lang -T-compiler
cc @jdonszelmann

(Separate question: Why does the "Future incompatibility report" only trigger if report_in_deps is true, even if the future incompatibility happens in the same crate, is this correct?)

This also needs a crater run, but I don't have permissions to trigger this

@JonathanBrouwer
Start reporting future breakage for ILL_FORMED_ATTRIBUTE_INPUT in d…
7bd902d 
…ependencies

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. I-lang-nominated Nominated for discussion during a lang team meeting. T-lang Relevant to the language team and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 27, 2025
@Urgau
Copy link
Member

Urgau commented Jul 27, 2025

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jul 27, 2025

⌛ Trying commit 7bd902d with merge d7b15db…

To cancel the try build, run the command @bors try cancel.

rust-bors bot added a commit that referenced this pull request Jul 27, 2025
@rust-bors
Auto merge of #144544 - JonathanBrouwer:illformed-in-deps, r=<try>
d7b15db 
Start reporting future breakage for `ILL_FORMED_ATTRIBUTE_INPUT` in dependencies
@rust-bors
Copy link

rust-bors bot commented Jul 27, 2025

☀️ Try build successful (CI)
Build commit: d7b15db (d7b15db413fd2070daa09a2c5b7f2ab38417429f, parent: 4b596bbd847672da87763b76171687d3544863c2)

@traviscross traviscross added the P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang label Jul 28, 2025
@traviscross
Copy link
Contributor

cc @rust-lang/lang @rust-lang/lang-advisors

@traviscross
Copy link
Contributor

It seems clear to me that we should do this in any event, so let's...

@rfcbot fcp merge

@rfcbot
Copy link
Collaborator

rfcbot commented Jul 28, 2025 •
edited
Loading

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 28, 2025
@jdonszelmann
Copy link
Contributor

@bors try

rust-bors bot added a commit that referenced this pull request Jul 28, 2025
@rust-bors
Auto merge of #144544 - JonathanBrouwer:illformed-in-deps, r=<try>
b19a6f8 
Start reporting future breakage for `ILL_FORMED_ATTRIBUTE_INPUT` in dependencies
@rust-bors
Copy link

rust-bors bot commented Jul 28, 2025

⌛ Trying commit 7bd902d with merge b19a6f8…

To cancel the try build, run the command @bors try cancel.

@jdonszelmann
Copy link
Contributor

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-144544 created and queued.
🤖 Automatically detected try build d7b15db
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2025
@jdonszelmann
Copy link
Contributor

@bors try cancel

@rust-bors
Copy link

rust-bors bot commented Jul 28, 2025

Try build cancelled. Cancelled workflows:

@craterbot
Copy link
Collaborator

🚧 Experiment pr-144544 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@traviscross traviscross

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. I-lang-nominated Nominated for discussion during a lang team meeting. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. S-waiting-on-crater Status: Waiting on a crater run to be completed. T-lang Relevant to the language team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JonathanBrouwer @Urgau @traviscross @rfcbot @jdonszelmann @craterbot @rustbot