Migrate UnsizedConstParamTy to unstable impl of ConstParamTy_
#145095
+259
−604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
fmease
added a commit
to fmease/rust
that referenced
this pull request
Aug 11, 2025
Support using #[unstable_feature_bound] on trait This is needed to unblock rust-lang#145095 r? `@BoxyUwU`
fmease
added a commit
to fmease/rust
that referenced
this pull request
Aug 12, 2025
Support using #[unstable_feature_bound] on trait This is needed to unblock rust-lang#145095 r? ``@BoxyUwU``
fmease
added a commit
to fmease/rust
that referenced
this pull request
Aug 12, 2025
Support using #[unstable_feature_bound] on trait This is needed to unblock rust-lang#145095 r? ```@BoxyUwU```
fmease
added a commit
to fmease/rust
that referenced
this pull request
Aug 12, 2025
Support using #[unstable_feature_bound] on trait This is needed to unblock rust-lang#145095 r? ````@BoxyUwU````
fmease
added a commit
to fmease/rust
that referenced
this pull request
Aug 12, 2025
Support using #[unstable_feature_bound] on trait This is needed to unblock rust-lang#145095 r? `````@BoxyUwU`````
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 12, 2025
Support using #[unstable_feature_bound] on trait This is needed to unblock rust-lang#145095 r? ``````@BoxyUwU``````
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 12, 2025
Support using #[unstable_feature_bound] on trait This is needed to unblock rust-lang#145095 r? ```````@BoxyUwU```````
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Aug 13, 2025
Support using #[unstable_feature_bound] on trait This is needed to unblock rust-lang/rust#145095 r? ```````@BoxyUwU```````
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Aug 18, 2025
Support using #[unstable_feature_bound] on trait This is needed to unblock rust-lang/rust#145095 r? ```````@BoxyUwU```````
rust-cloud-vms
bot
force-pushed
the
unstable_const_param
branch
from
a4bd0a8 to
262cf11
Compare
BoxyUwU
reviewed
Aug 19, 2025
| Ok(()) | ||
| }) | ||
| } else if tcx.features().adt_const_params() { | ||
| if tcx.features().adt_const_params() || tcx.features().unsized_const_params() { |
There was a problem hiding this comment.
we should make unsized_const_params no longer be a lang feature. you can do this by removing its entry from unstable.rs
|
Currently all tests in |
|
☔ The latest upstream changes (presumably #145773) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have
#[unstable_feature_bound], we can removeUnsizedConstParamTythat was meant to be an unstable impl of stable type andConstParamTy_trait.r? @BoxyUwU