Skip to content

Don't strip shebang in expr-ctxt include!(…) #146377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fmease wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't strip shebang in expr-ctxt include!(…) #146377

fmease wants to merge 1 commit into from
+60 −3

Conversation

@fmease
Copy link
Member

@fmease fmease commented Sep 9, 2025 •
edited
Loading

No longer strip shebang interpreter directives in files that were included in expression (statement) contexts.

@fmease fmease added T-lang Relevant to the language team S-waiting-on-team DEPRECATED: Use the team-based variants `S-waiting-on-t-lang`, `S-waiting-on-t-compiler`, ... S-blocked Status: Blocked on something else such as an RFC or other implementation work. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. labels Sep 9, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. labels Sep 9, 2025
@fmease fmease changed the title [STACKED] Don't strip shebang in expr-ctxt include!(…)s [STACKED] Don't strip shebang in expr-ctxt include!(…) Sep 9, 2025
@fmease fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 9, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fmease fmease force-pushed the no-incl-shebang-expr branch from c611f6f to 3685183 Compare September 9, 2025 18:10
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fmease fmease force-pushed the no-incl-shebang-expr branch from 3685183 to 77cd6d1 Compare September 9, 2025 18:27
@Urgau Urgau removed the S-waiting-on-team DEPRECATED: Use the team-based variants `S-waiting-on-t-lang`, `S-waiting-on-t-compiler`, ... label Oct 6, 2025
@fmease fmease mentioned this pull request Oct 23, 2025
Open
10 tasks
@traviscross traviscross added the I-lang-radar Items that are on lang's radar and will need eventual work or consideration. label Oct 23, 2025
@fmease fmease force-pushed the no-incl-shebang-expr branch from 77cd6d1 to e8ef799 Compare November 25, 2025 23:59
@fmease fmease changed the title [STACKED] Don't strip shebang in expr-ctxt include!(…) Don't strip shebang in expr-ctxt include!(…) Nov 25, 2025
@fmease fmease added needs-crater This change needs a crater run to check for possible breakage in the ecosystem. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Nov 26, 2025
@fmease fmease force-pushed the no-incl-shebang-expr branch from e8ef799 to e477732 Compare November 26, 2025 03:58
@fmease fmease added I-lang-nominated Nominated for discussion during a lang team meeting. S-waiting-on-t-lang Status: Awaiting decision from T-lang and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 26, 2025
@fmease fmease marked this pull request as ready for review November 26, 2025 03:58
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2025
@fmease fmease removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2025
@rust-bors
Copy link

rust-bors bot commented Nov 26, 2025

☀️ Try build successful (CI)
Build commit: 3a4cb0e (3a4cb0edb4040379c037e06efeb5409e44be7b77, parent: c797096598b80ba4a40397ad7e91584fcd3df5f1)

@traviscross
Copy link
Contributor

traviscross commented Nov 26, 2025

@craterbot check

@craterbot
Copy link
Collaborator

craterbot commented Nov 26, 2025

👌 Experiment pr-146377 created and queued.
🤖 Automatically detected try build 3a4cb0e
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-t-lang Status: Awaiting decision from T-lang labels Nov 26, 2025
@fmease fmease mentioned this pull request Nov 28, 2025
Open
@craterbot
Copy link
Collaborator

craterbot commented Dec 4, 2025

🚧 Experiment pr-146377 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Dec 6, 2025

🎉 Experiment pr-146377 is completed!
📊 5 regressed and 5 fixed (745385 total)
📊 2102 spurious results on the retry-regessed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-146377/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 6, 2025
@traviscross
Copy link
Contributor

traviscross commented Dec 6, 2025

@craterbot check p=1 crates=https://crater-reports.s3.amazonaws.com/pr-146377/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

craterbot commented Dec 6, 2025

👌 Experiment pr-146377-1 created and queued.
🤖 Automatically detected try build 3a4cb0e
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2025
@craterbot
Copy link
Collaborator

craterbot commented Dec 7, 2025

🚧 Experiment pr-146377-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Dec 7, 2025

🎉 Experiment pr-146377-1 is completed!
📊 0 regressed and 0 fixed (1875 total)
📊 119 spurious results on the retry-regessed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-146377-1/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 7, 2025
@joshtriplett joshtriplett removed the needs-crater This change needs a crater run to check for possible breakage in the ecosystem. label Dec 10, 2025
@traviscross
Copy link
Contributor

traviscross commented Dec 10, 2025 •
edited
Loading

We talked about this in the lang meeting today, and this does seem the best step.

@rfcbot fcp merge lang

@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Dec 10, 2025 •
edited
Loading

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Dec 10, 2025
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Dec 10, 2025

@rfcbot reviewed

@rust-rfcbot rust-rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Dec 10, 2025
@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Dec 10, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@traviscross traviscross removed I-lang-nominated Nominated for discussion during a lang team meeting. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang labels Dec 10, 2025
@epage epage mentioned this pull request Dec 12, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Urgau Urgau

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-lang Relevant to the language team T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@fmease @rust-log-analyzer @traviscross @joshtriplett @jackh726 @craterbot @rust-rfcbot @nikomatsakis @Urgau @rustbot