Skip to content

Conversation

@tamird
Copy link
Contributor

@tamird tamird commented Nov 9, 2025

Discussed in #148531 (comment).

r? @bjorn3

@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2025

Some changes occurred in cfg and check-cfg configuration

cc @Urgau

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 9, 2025
@tamird tamird force-pushed the avoid-vendor-logic branch from e1af253 to 40cc725 Compare November 9, 2025 21:01
Copy link
Contributor

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot rustbot assigned madsmtm and unassigned bjorn3 Nov 9, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2025
@madsmtm
Copy link
Contributor

madsmtm commented Nov 9, 2025

@bors rollup delegate+

Feel free to r=me with the comments resolved (if you think they're worth resolving).

@bors
Copy link
Collaborator

bors commented Nov 9, 2025

✌️ @tamird, you can now approve this pull request!

If @madsmtm told you to "r=me" after making some further change, please make that change, then do @bors r=@madsmtm

@rust-log-analyzer

This comment has been minimized.

@tamird tamird force-pushed the avoid-vendor-logic branch from 40cc725 to c5f2eb6 Compare November 9, 2025 22:44
@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@tamird
Copy link
Contributor Author

tamird commented Nov 9, 2025

@bors r=@madsmtm

@bors
Copy link
Collaborator

bors commented Nov 9, 2025

📌 Commit c5f2eb6 has been approved by madsmtm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 9, 2025
@madsmtm madsmtm added the A-target-specs Area: Compile-target specifications label Nov 10, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 10, 2025
rustc_target: hide TargetOptions::vendor

Discussed in rust-lang#148531 (comment).

r? `@bjorn3`
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 10, 2025
rustc_target: hide TargetOptions::vendor

Discussed in rust-lang#148531 (comment).

r? ``@bjorn3``
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Nov 10, 2025
rustc_target: hide TargetOptions::vendor

Discussed in rust-lang#148531 (comment).

r? ``@bjorn3``
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Nov 10, 2025
rustc_target: hide TargetOptions::vendor

Discussed in rust-lang#148531 (comment).

r? ```@bjorn3```
bors added a commit that referenced this pull request Nov 10, 2025
Rollup of 9 pull requests

Successful merges:

 - #148480 (Add `Steal::risky_hack_borrow_mut`)
 - #148608 (Add test for --test-builder success path)
 - #148667 (a few small clippy fixes)
 - #148712 (Port `cfg_select!` to the new attribute parsing system)
 - #148760 (rustc_target: hide TargetOptions::vendor)
 - #148775 (Fix a typo in the documentation for the strict_shr function)
 - #148779 (Implement DynSend and DynSync for std::panic::Location.)
 - #148781 ([rustdoc] Remove unneeded `allow(rustc::potential_query_instability)`)
 - #148791 (fix "is_closure_like" doc comment)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 11, 2025
rustc_target: hide TargetOptions::vendor

Discussed in rust-lang#148531 (comment).

r? ````@bjorn3````
bors added a commit that referenced this pull request Nov 11, 2025
Rollup of 13 pull requests

Successful merges:

 - #148694 (std: support `RwLock` and thread parking on TEEOS)
 - #148712 (Port `cfg_select!` to the new attribute parsing system)
 - #148760 (rustc_target: hide TargetOptions::vendor)
 - #148771 (IAT: Reinstate early bailout)
 - #148775 (Fix a typo in the documentation for the strict_shr function)
 - #148779 (Implement DynSend and DynSync for std::panic::Location.)
 - #148781 ([rustdoc] Remove unneeded `allow(rustc::potential_query_instability)`)
 - #148783 (add test for assoc type norm wf check)
 - #148785 (Replace `master` branch references with `main`)
 - #148791 (fix "is_closure_like" doc comment)
 - #148792 (Prefer to use file.stable_id over file.name from source map)
 - #148805 (rustc-dev-guide subtree update)
 - #148807 (Document (and test) a problem with `Clone`/`Copy` deriving.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d738f03 into rust-lang:main Nov 11, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 11, 2025
rust-timer added a commit that referenced this pull request Nov 11, 2025
Rollup merge of #148760 - tamird:avoid-vendor-logic, r=madsmtm

rustc_target: hide TargetOptions::vendor

Discussed in #148531 (comment).

r? `````@bjorn3`````
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-target-specs Area: Compile-target specifications S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants