IAT: Reinstate early bailout #148771
IAT: Reinstate early bailout #148771
Conversation
fmease
added
F-inherent_associated_types
rustbot
added
the
S-waiting-on-review
|
|
fmease
force-pushed
the
iat-reinstate-early-elim
branch
from
f35de59 to
129c7f0
Compare
| Some(InherentAssocCandidate { impl_, assoc_item: item.def_id, scope }) | ||
| }) | ||
| .collect(); | ||
|
|
There was a problem hiding this comment.
Obviously this is but a hotfix for a minute part of #142006. I was briefly toying with the idea of properly addressing #142006 now but for that I would need to rewrite type-relative path resolution in HIR ty lowering to properly assemble inherent & trait candidates (instead of eagerly trying to resolve them in sequence) but I realized I would only be stepping on your toes / doing throwaway work (#145825).
There was a problem hiding this comment.
I wrote this test and it's rooted in a deep misconception, namely that there can't ever be a case where we would pick a trait candidate over an inherent one. Back then I didn't know about #142006.
In essence, I don't like this test, hence its removal. Once we fix #142006, we'll have plenty of tests regarding "candidate preference/elimination".
fmease
force-pushed
the
iat-reinstate-early-elim
branch
from
129c7f0 to
a9fd741
Compare
fmease
force-pushed
the
iat-reinstate-early-elim
branch
from
a9fd741 to
6ed469c
Compare
fmease
changed the title
|
@bors r+ lgtm. i thought i'd get around to fixing type relative path lowering sooner than it seems like I actually am going to be so this seems reasonable for the time being |
bors
added
S-waiting-on-bors
…=BoxyUwU IAT: Reinstate early bailout Apparently, some people are already using IATs in their projects and get blocked by rust-lang#142006 (comment) (cc dupes rust-lang#143952 & rust-lang#148535). Since the (temporary) fix is so trivial, let's just do it. Addresses rust-lang#142006 (comment). cc `@luissantosHCIT` (rust-lang#148535). r? `@BoxyUwU`
…=BoxyUwU IAT: Reinstate early bailout Apparently, some people are already using IATs in their projects and get blocked by rust-lang#142006 (comment) (cc dupes rust-lang#143952 & rust-lang#148535). Since the (temporary) fix is so trivial, let's just do it. Addresses rust-lang#142006 (comment). cc ``@luissantosHCIT`` (rust-lang#148535). r? ``@BoxyUwU``
4 participants
Apparently, some people are already using IATs in their projects and get blocked by #142006 (comment) (cc dupes #143952 & #148535). Since the (temporary) fix is so trivial, let's just do it.
Addresses #142006 (comment).
cc @luissantosHCIT (#148535).
r? @BoxyUwU