-
Notifications
You must be signed in to change notification settings - Fork 14k
rustc_target: aarch64: Remove deprecated FEAT_TME #148951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
improve `_mm256_permute2f128` tests
Forward `TEST_SAMPLE_INTRINSICS_PERCENTAGE`
Add intrinsics for the new AMX target features
This updates the rust-version file to 8401398.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: 8401398 Filtered ref: f9e99a8e85fa360f0e820dc75d46cb4583b4300d Upstream diff: rust-lang/rust@73e6c9e...8401398 This merge was created using https://github.com/rust-lang/josh-sync.
Rustc pull update
previously the output would just always be all zeroes
add logic tests for ternarylogic
Use generic SIMD masked load/stores for avx512 masked load/stores
improve ternary logic tests
Use SIMD intrinsics for vector shifts
This comment has been minimized.
This comment has been minimized.
688954b to
8f7dadd
Compare
This comment has been minimized.
This comment has been minimized.
|
The feature being "stable" while the intrinsics are not effectively means we should only continue recognizing the name and not emit an error or warning when someone passes it, that's all. I don't think we have to even try to do codegen for it. |
correct some `#[simd_test]` attributes
aarch64: Remove withdrawn FEAT_TME
…h-to-main rename default branch to main
…dness correct signedness of pmadd arguments
|
Hey! This is currently blocking the Rust roll into the Fuchsia project's toolchain, and we'd expect that other open source projects that track Rust/LLVM at head are similarly blocked. Can we get the workaround mentioned above landed quickly? I can spare time to help with this, but I'm not tremendously familiar with rustc as of yet. |
|
Reminder, once the PR becomes ready for a review, use |
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
|
@rustbot ready I've made the requested change, and put it on top of a |
This comment has been minimized.
This comment has been minimized.
|
@rustbot author Waiting on landing stdarch update in rustc. |
ARM has withdrawn FEAT_TME https://developer.arm.com/documentation/102105/lb-05/ LLVM has dropped support for it recently as a result.
The rustbot message on modifying stdarch is just advice; if you are actually editing rustc and stdarch together (without a reasonable way to decouple the changes), it is best to just do them simply (after all this was the motivation behind migrating to josh from submodules). You don't need to do the |
|
What's causing us grief here really is that this repository does not (yet) run the I'm sure the josh stuff is better than the alternatives, but I fully agree that it is not very user-friendly, and its errors are unhelpful to normal users. |
ARM has withdrawn FEAT_TME
https://developer.arm.com/documentation/102105/lb-05/
LLVM has dropped support for generating it
llvm/llvm-project#167687
@rustbot label llvm-main
r? @durin42