Skip to content

Conversation

@maurer
Copy link
Contributor

@maurer maurer commented Nov 14, 2025

ARM has withdrawn FEAT_TME

https://developer.arm.com/documentation/102105/lb-05/

LLVM has dropped support for generating it
llvm/llvm-project#167687

@rustbot label llvm-main

r? @durin42

folkertdev and others added 22 commits October 27, 2025 00:28
Forward `TEST_SAMPLE_INTRINSICS_PERCENTAGE`
Add intrinsics for the new AMX target features
This updates the rust-version file to 8401398.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: 8401398
Filtered ref: f9e99a8e85fa360f0e820dc75d46cb4583b4300d
Upstream diff: rust-lang/rust@73e6c9e...8401398

This merge was created using https://github.com/rust-lang/josh-sync.
previously the output would just always be all zeroes
Use generic SIMD masked load/stores for avx512 masked load/stores
Use SIMD intrinsics for vector shifts
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) labels Nov 14, 2025
@rustbot

This comment has been minimized.

@maurer maurer force-pushed the remove-tme branch 2 times, most recently from 688954b to 8f7dadd Compare November 14, 2025 19:00
@rust-log-analyzer

This comment has been minimized.

@workingjubilee
Copy link
Member

workingjubilee commented Nov 15, 2025

The feature being "stable" while the intrinsics are not effectively means we should only continue recognizing the name and not emit an error or warning when someone passes it, that's all. I don't think we have to even try to do codegen for it.

@mysterymath
Copy link

Hey! This is currently blocking the Rust roll into the Fuchsia project's toolchain, and we'd expect that other open source projects that track Rust/LLVM at head are similarly blocked. Can we get the workaround mentioned above landed quickly? I can spare time to help with this, but I'm not tremendously familiar with rustc as of yet.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

⚠️ Warning ⚠️

@rustbot rustbot added the has-merge-commits PR has merge commits, merge with caution. label Nov 19, 2025
@maurer
Copy link
Contributor Author

maurer commented Nov 19, 2025

@rustbot ready

I've made the requested change, and put it on top of a josh-sync of stdarch rather than editing stdarch directly. rustbot seems upset that josh generates merge commits, so perhaps I've done that step wrong. If someone either wants to point me to what I did wrong in trying to sync stdarch back or to update it themselves, I'll rebase, but this commit should match what was requested now.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 19, 2025
@rust-log-analyzer

This comment has been minimized.

@maurer
Copy link
Contributor Author

maurer commented Nov 19, 2025

@rustbot author

Waiting on landing stdarch update in rustc.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2025
ARM has withdrawn FEAT_TME

https://developer.arm.com/documentation/102105/lb-05/

LLVM has dropped support for it recently as a result.
@sayantn
Copy link
Contributor

sayantn commented Nov 19, 2025

Am I missing something obvious? How do other people deal with this?

The rustbot message on modifying stdarch is just advice; if you are actually editing rustc and stdarch together (without a reasonable way to decouple the changes), it is best to just do them simply (after all this was the motivation behind migrating to josh from submodules). You don't need to do the josh-sync at all (that's independent of this PR).

@folkertdev
Copy link
Contributor

What's causing us grief here really is that this repository does not (yet) run the stdarch tests. If it did, we could make changes to stdarch with more confidence in this repository. So for the time being, complex changes that touch both need this synchronization dance, thankfully that is quite rare.

I'm sure the josh stuff is better than the alternatives, but I fully agree that it is not very user-friendly, and its errors are unhelpful to normal users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. has-merge-commits PR has merge commits, merge with caution. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants