Run codegen tests on a 32-bit target in PR CI #148958
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-CI
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
32bit-codegen-pr
branch
from
59a8618 to
bf8e5a6
Compare
Member
Author
|
r? Kobzol |
rustbot
added
S-waiting-on-review
Member
|
Could you please just add a comment on top of it to explain why we included this specific test invocation? The Dockerfiles are filled with random You can r=me after. |
saethlin
force-pushed
the
32bit-codegen-pr
branch
from
bf8e5a6 to
64f0579
Compare
Member
Author
|
@bors r=kobzol |
Collaborator
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Nov 17, 2025
Run codegen tests on a 32-bit target in PR CI wasm32-wasip1 is the wasm target used in test-various. So using it somewhere else seems like a good bet.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 17, 2025
Run codegen tests on a 32-bit target in PR CI wasm32-wasip1 is the wasm target used in test-various. So using it somewhere else seems like a good bet.
Zalathar
reviewed
Nov 17, 2025
Comment on lines
+37
to
+40
| # Elsewhere, we run all tests for the host. A number of codegen tests are sensitive to the target pointer | ||
| # width, for example because they mention a usize. wasm32-wasip1 in test-various, so using it here can't make | ||
| # PR CI more strict than full CI. | ||
| python3 ../x.py test --stage 1 tests/codegen-llvm --target wasm32-wasip1 && \ |
Member
There was a problem hiding this comment.
Remark: IIRC, full CI is a proper superset of PR CI nowadays, so being more strict in PR CI is no longer a major concern.
(But it's still good to know that this is intended to be a subset of checks that run elsewhere in full CI.) 👍
Member
There was a problem hiding this comment.
Yes, unless one writes a separate GHA workflow, citool enforces an invariant that PR CI is subset of Merge CI (modulo some carve-out differences).
bors
added a commit
that referenced
this pull request
Nov 17, 2025
Rollup of 6 pull requests Successful merges: - #147760 ([Debugger Visualizers] Unify `*-gnu` and `*-msvc` enum output) - #148505 (add larger test for `proc_macro` `FromStr` implementations) - #148855 (Error if an autodiff user does not set lto=fat) - #148958 (Run codegen tests on a 32-bit target in PR CI) - #149004 (compiletest: Avoid race condition in file deletion) - #149008 (triagebot: remove jsha from notifications for rustdoc HTML) r? `@ghost` `@rustbot` modify labels: rollup
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 17, 2025
Run codegen tests on a 32-bit target in PR CI wasm32-wasip1 is the wasm target used in test-various. So using it somewhere else seems like a good bet.
This was referenced Nov 17, 2025
bors
added a commit
that referenced
this pull request
Nov 17, 2025
Rollup of 11 pull requests Successful merges: - #148505 (add larger test for `proc_macro` `FromStr` implementations) - #148752 (Constify `ManuallyDrop::take`) - #148757 (Constify `mem::take`) - #148855 (Error if an autodiff user does not set lto=fat) - #148912 (add note to `lines` docs about empty str behavior) - #148958 (Run codegen tests on a 32-bit target in PR CI) - #148994 (Abi compatibility test cleanup) - #148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS) - #149004 (compiletest: Avoid race condition in file deletion) - #149008 (triagebot: remove jsha from notifications for rustdoc HTML) - #149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 17, 2025
Rollup merge of #148958 - saethlin:32bit-codegen-pr, r=kobzol Run codegen tests on a 32-bit target in PR CI wasm32-wasip1 is the wasm target used in test-various. So using it somewhere else seems like a good bet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm32-wasip1 is the wasm target used in test-various. So using it somewhere else seems like a good bet.