Replace -Zon-broken-pipe=... with Externally Implementable Item #[std::io::on_broken_pipe]
#150591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
Enselic
changed the title
#![feature(on_broken_pipe)] code
This comment has been minimized.
This comment has been minimized.
Enselic
force-pushed
the
add-on_broken_pipe
branch
from
7ce0046 to
5825fb6
Compare
So that the name is semantically correct for `#[feature(on_broken_pipe)]` (and actually also `-Zon-broken-pipe` if we end up keeping that).
…position So we don't need to update the test when the implementation changes. The default will work fine. No need to set it explicitly to Error. That is the default.
Enselic
force-pushed
the
add-on_broken_pipe
branch
from
5825fb6 to
7b52018
Compare
rustbot
added
A-compiletest
Enselic
changed the title
#![feature(on_broken_pipe)] code-Zon-broken-pipe=... with Externally Implementable Item #[std::io::on_broken_pipe() -> std::io::OnBrokenPipe
Enselic
changed the title
-Zon-broken-pipe=... with Externally Implementable Item #[std::io::on_broken_pipe() -> std::io::OnBrokenPipe-Zon-broken-pipe=... with Externally Implementable Item #[std::io::on_broken_pipe]
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
RalfJung
reviewed
Jan 6, 2026
Comment on lines
+314
to
+320
| // `std::io::on_broken_pipe` is implemented via EII and becomes an `extern "Rust"` | ||
| // function without a body. Under v0 mangling this shows up with a mangled symbol name | ||
| // (e.g. `_RNv..._3std2io14on_broken_pipe`). | ||
| // | ||
| // Miri does not support the real behavior (changing host SIGPIPE disposition), so we | ||
| // treat this as a no-op and request inheriting SIGPIPE. | ||
| name if name == "on_broken_pipe" || name.contains("std2io14on_broken_pipe") => { |
Member
There was a problem hiding this comment.
I assume this is just for testing for now, but this hack is definitely not something we'd want to land.
The proper fix here is to implement EII in Miri, so that the real implementation gets invoked. We already have hacks in place to ignore std trying to change the host SIGPIPE disposition.
This was referenced Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in this PR also acts as a regression test for the fix to #150588 which I will split out in a separate PR.
TODO
missing stability attributeerrors with trivial Externally Implementable Item (eii) function inlibrary/std#150514 first in a separate PR (see compiler: Make Externally Implementable Items (eii) in std build #150592)Tracking Issues:
#[std::io::on_broken_pipe]#150588