Skip to content

Conversation

@antonilol
Copy link
Contributor

@antonilol antonilol commented Jan 2, 2026

Tracking issue: #146975

This specialization makes sure deque1.prepend(deque2.drain(..)) gets similar speed to deque1.append(&mut deque2). deque1.prepend(deque2.drain(..)) is the equivalent of deque1.append(&mut deque2) but appending to the front (see the second example of prepend, prepend is from the same tracking issue).

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 2, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2026

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This is used when moving elements between `VecDeque`s
This pattern is also used in examples of `VecDeque::prepend`. (see its docs)
@antonilol antonilol force-pushed the deque_extend_front_prepend_drain_spec branch from 887bb5a to 7e425b8 Compare January 2, 2026 15:05
@jhpratt
Copy link
Member

jhpratt commented Jan 4, 2026

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jan 4, 2026

📌 Commit 7e425b8 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026
@bors
Copy link
Collaborator

bors commented Jan 4, 2026

⌛ Testing commit 7e425b8 with merge f280e76...

@bors
Copy link
Collaborator

bors commented Jan 4, 2026

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing f280e76 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors bors merged commit f280e76 into rust-lang:main Jan 4, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e25ee6b (parent) -> f280e76 (this PR)

Test differences

Show 4 test diffs

Stage 1

  • vec_deque::test_extend_front_specialization_deque_drain: [missing] -> pass (J0)

Stage 2

  • vec_deque::test_extend_front_specialization_deque_drain: [missing] -> pass (J1)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f280e764d51976d62da12033ddcbf72d0076a969 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 2006.6s -> 1506.0s (-24.9%)
  2. aarch64-apple: 11262.2s -> 8644.7s (-23.2%)
  3. x86_64-gnu-debug: 7951.6s -> 6297.6s (-20.8%)
  4. x86_64-rust-for-linux: 3088.5s -> 2665.5s (-13.7%)
  5. aarch64-gnu-debug: 4711.8s -> 4113.3s (-12.7%)
  6. dist-powerpc-linux: 5115.8s -> 5650.6s (+10.5%)
  7. aarch64-gnu: 7232.1s -> 7977.3s (+10.3%)
  8. i686-gnu-1: 8242.4s -> 7423.0s (-9.9%)
  9. x86_64-gnu-miri: 4950.6s -> 4458.6s (-9.9%)
  10. dist-ohos-x86_64: 4214.6s -> 4620.1s (+9.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f280e76): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.697s -> 474.288s (0.12%)
Artifact size: 390.82 MiB -> 390.82 MiB (-0.00%)

@antonilol antonilol deleted the deque_extend_front_prepend_drain_spec branch January 4, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants