-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Add specialization for deque1.prepend(deque2.drain(range)) (VecDeque::prepend and extend_front)
#150595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specialization for deque1.prepend(deque2.drain(range)) (VecDeque::prepend and extend_front)
#150595
Conversation
b8b94d7 to
887bb5a
Compare
This is used when moving elements between `VecDeque`s This pattern is also used in examples of `VecDeque::prepend`. (see its docs)
887bb5a to
7e425b8
Compare
|
@bors r+ rollup=never |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing e25ee6b (parent) -> f280e76 (this PR) Test differencesShow 4 test diffsStage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard f280e764d51976d62da12033ddcbf72d0076a969 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (f280e76): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.697s -> 474.288s (0.12%) |
Tracking issue: #146975
This specialization makes sure
deque1.prepend(deque2.drain(..))gets similar speed todeque1.append(&mut deque2).deque1.prepend(deque2.drain(..))is the equivalent ofdeque1.append(&mut deque2)but appending to the front (see the second example of prepend, prepend is from the same tracking issue).