support c-variadic functions in rustc_const_eval
#150601
Draft
+727
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
added
A-const-eval
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
however `Drop` for `VaList` is not yet available in const fn
folkertdev
force-pushed
the
c-variadic-const-eval
branch
from
d30044f to
5f98625
Compare
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
c-variadic-const-eval
branch
from
5f98625 to
3368321
Compare
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
c-variadic-const-eval
branch
from
3368321 to
41a34bc
Compare
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
c-variadic-const-eval
branch
from
41a34bc to
8608ba7
Compare
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
c-variadic-const-eval
branch
from
8608ba7 to
207b032
Compare
|
☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking issue: #44930
The new
GlobalAlloc::VaListis used to create anAllocIdthat represents the variable argument list of a frame. The allocation itself does not store any data, all we need is the unique identifier.The actual variable argument list is stored in
Memory, and keyed by theAllocId. TheFramealso stores thisAllocId, so that when a frame is popped, it can deallocate the variable arguments.At "runtime" a
VaListvalue stores a pointer to the global allocation in its first bytes. The provenance on this pointer can be used to retrieve itsAllocId, and the offset of the pointer is used to store the index of the next argument to read from the variable argument list.Miri does not yet support
va_arg, but I think that can be done separetely?r? @RalfJung
cc @workingjubilee