Unify and deduplicate From<bool> float tests #150611
Open
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
Unify the From<bool> tests from f16.rs and f128.rs into a single float_test! in mod.rs.
augustocesarperin
force-pushed
the
from-bool-float-test
branch
from
3f94742 to
357ec46
Compare
Member
|
@rustbot reroll |
Member
Mark-Simulacrum
requested changes
Jan 4, 2026
| assert_biteq!(f16::from(u8::MAX), 255.0); | ||
| assert_biteq!(f16::from(i8::MIN), -128.0); | ||
| assert_biteq!(f16::from(42_i8), 42.0); | ||
| assert_biteq!(f16::from(i8::MAX), 127.0); |
Member
There was a problem hiding this comment.
Why only the bools, and not the rest of the cases here?
Member
There was a problem hiding this comment.
Probably because they want to know whether they are on the right track, given this is their first PR here.
Are you saying they are on the right track and should add more?
rustbot
removed
the
S-waiting-on-review
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
Contributor
|
I believe this will be superseded by #148206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #141726
Unify the From tests from f16.rs and f128.rs into a single float_test! in mod.rs.