Merge `associated_const_equality` feature gate into MGCA #150640

AprilNEA · 2026-01-03T09:52:25Z

Tracking Issues: #132980 #92827

Merge associated_const_equality(ACE) feature gate into min_generic_const_args(MGCA).

Replaces features().associated_const_equality() checks with features().min_generic_const_args()
Updates the parser to gate associated const equality under min_generic_const_args
Moves associated_const_equality to the removed features list
Removes the associated_const_equality method from the Features trait
Updates all affected tests and tools (rust-analyzer, clippy)

Closes #150617

r? @BoxyUwU

rustbot · 2026-01-03T09:52:29Z

HIR ty lowering was modified

cc @fmease

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

rustbot · 2026-01-03T09:52:31Z

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

fmease

Thanks for working on this!

Could you additionally replace all occurrences of FIXME(associated_const_equality) with FIXME(mgca)? Thanks in advance!

View changes since this review

AprilNEA · 2026-01-03T10:27:32Z

Could you additionally replace all occurrences of FIXME(associated_const_equality) with FIXME(mgca)? Thanks in advance!

Sure.

tests/ui/traits/next-solver/dont-ice-on-assoc-projection.stderr

BoxyUwU · 2026-01-04T01:07:14Z

@rustbot author

rustbot · 2026-01-04T01:07:19Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

AprilNEA · 2026-01-04T05:06:48Z

@rustbot ready

BoxyUwU

Thanks this all looks good to me. I think this PR will merge conflict with #150650 so we'll wait for that to land before merging this. Once it lands you'll need to rebase this PR

It'd also be good if you could squash all of your commits into one

View changes since this review

rust-bors · 2026-01-04T17:02:54Z

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2026-01-04T18:01:36Z

☔ The latest upstream changes (presumably #150669) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2026-01-05T03:56:32Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

This removes `associated_const_equality` as a separate feature gate and makes it part of `min_generic_const_args` (mgca). Key changes: - Remove `associated_const_equality` from unstable features, add to removed - Update all test files to use `min_generic_const_args` instead - Preserve the original "associated const equality is incomplete" error message by specially handling `sym::associated_const_equality` spans in `feature_gate.rs` - Rename FIXME(associated_const_equality) to FIXME(mgca)

AprilNEA · 2026-01-05T07:25:51Z

@rustbot ready

BoxyUwU · 2026-01-05T14:03:03Z

@bors r+ rollup=never

bors · 2026-01-05T14:03:06Z

📌 Commit 4421270 has been approved by BoxyUwU

It is now in the queue for this repository.

bors · 2026-01-06T01:36:57Z

⌛ Testing commit 4421270 with merge da476f1...

bors · 2026-01-06T04:52:21Z

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing da476f1 to main...

github-actions · 2026-01-06T04:55:26Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7c04f5d (parent) -> da476f1 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard da476f1942868cdf94ed88b01ea31170cfe95047 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 8059.4s -> 11247.2s (+39.6%)
pr-check-1: 1509.4s -> 2004.3s (+32.8%)
x86_64-gnu-tools: 3000.8s -> 3614.8s (+20.5%)
x86_64-gnu-gcc: 3244.6s -> 3766.3s (+16.1%)
x86_64-gnu-debug: 6265.8s -> 7271.0s (+16.0%)
x86_64-rust-for-linux: 2822.1s -> 3167.0s (+12.2%)
pr-check-2: 2326.7s -> 2597.9s (+11.7%)
arm-android: 5755.7s -> 6405.1s (+11.3%)
dist-aarch64-apple: 6989.5s -> 7763.7s (+11.1%)
test-various: 6724.8s -> 7413.1s (+10.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-01-06T05:33:32Z

Finished benchmarking commit (da476f1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.09s -> 473.133s (-0.41%)
Artifact size: 390.73 MiB -> 390.77 MiB (0.01%)

…-equality, r=BoxyUwU Merge `associated_const_equality` feature gate into MGCA Tracking Issues: rust-lang#132980 rust-lang#92827 Merge `associated_const_equality`(ACE) feature gate into `min_generic_const_args`(MGCA). - Replaces `features().associated_const_equality()` checks with `features().min_generic_const_args()` - Updates the parser to gate associated const equality under `min_generic_const_args` - Moves `associated_const_equality` to the removed features list - Removes the `associated_const_equality` method from the `Features` trait - Updates all affected tests and tools (rust-analyzer, clippy) Closes rust-lang#150617 r? `@BoxyUwU`

rustbot assigned BoxyUwU Jan 3, 2026

fmease reviewed Jan 3, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

BoxyUwU reviewed Jan 4, 2026

View reviewed changes

tests/ui/traits/next-solver/dont-ice-on-assoc-projection.stderr Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026

This comment has been minimized.

Sign in to view

AprilNEA force-pushed the mgca-merge-associated-const-equality branch from a7752be to 9885ffb Compare January 4, 2026 03:48

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 4, 2026

BoxyUwU approved these changes Jan 4, 2026

View reviewed changes

AprilNEA force-pushed the mgca-merge-associated-const-equality branch 2 times, most recently from 4db26df to 62b56b7 Compare January 4, 2026 06:05

fmease added the F-associated_const_equality `#![feature(associated_const_equality)]` label Jan 4, 2026

fmease added this to Associated Const Equality (ACE) Jan 4, 2026

fmease moved this to In Progress in Associated Const Equality (ACE) Jan 4, 2026

This comment has been minimized.

Sign in to view

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 5, 2026

AprilNEA force-pushed the mgca-merge-associated-const-equality branch from 88b620e to 4421270 Compare January 5, 2026 04:35

rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Jan 5, 2026

BoxyUwU mentioned this pull request Jan 5, 2026

Tracking Issue for Generic Constant Arguments MVP #132980

Open

29 tasks

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2026

BoxyUwU mentioned this pull request Jan 5, 2026

MGCA: Const constructors support #150704

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 6, 2026

bors merged commit da476f1 into rust-lang:main Jan 6, 2026
12 checks passed

github-project-automation bot moved this from In Progress to Done in Associated Const Equality (ACE) Jan 6, 2026

rustbot added this to the 1.94.0 milestone Jan 6, 2026

bors mentioned this pull request Jan 6, 2026

Rename tests/rustdoc into tests/rustdoc-html #150645

Merged

fmease mentioned this pull request Jan 7, 2026

Tracking issue for associated const equality #92827

Open

8 tasks

Uh oh!

Merge associated_const_equality feature gate into MGCA #150640

Merge associated_const_equality feature gate into MGCA #150640

Uh oh!

Conversation

AprilNEA commented Jan 3, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jan 3, 2026

Uh oh!

rustbot commented Jan 3, 2026

Uh oh!

fmease left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

AprilNEA commented Jan 3, 2026

Uh oh!

This comment has been minimized.

Uh oh!

BoxyUwU commented Jan 4, 2026

Uh oh!

rustbot commented Jan 4, 2026

Uh oh!

This comment has been minimized.

AprilNEA commented Jan 4, 2026

Uh oh!

BoxyUwU left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors bot commented Jan 4, 2026

Uh oh!

bors commented Jan 4, 2026

Uh oh!

rustbot commented Jan 5, 2026

Uh oh!

This comment has been minimized.

AprilNEA commented Jan 5, 2026

Uh oh!

BoxyUwU commented Jan 5, 2026

Uh oh!

bors commented Jan 5, 2026

Uh oh!

bors commented Jan 6, 2026

Uh oh!

bors commented Jan 6, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 6, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Jan 6, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Merge `associated_const_equality` feature gate into MGCA #150640

Merge `associated_const_equality` feature gate into MGCA #150640

AprilNEA commented Jan 3, 2026 •

edited by rustbot

Loading

fmease left a comment •

edited by rustbot

Loading

BoxyUwU left a comment •

edited

Loading