-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
mutex.rs: remove needless-maybe-unsized bounds #150642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Member
|
@bors r+ rollup |
Collaborator
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jan 4, 2026
…pratt
mutex.rs: remove needless-maybe-unsized bounds
Fixes for:
```text
warning: `?Sized` bound is ignored because of a `Sized` requirement
--> library/std/src/sync/nonpoison/mutex.rs:425:9
|
425 | impl<T: ?Sized + Default> Default for Mutex<T> {
| ^^^^^^
|
note: `T` cannot be unsized because of the bound
--> library/std/src/sync/nonpoison/mutex.rs:425:18
|
425 | impl<T: ?Sized + Default> Default for Mutex<T> {
| ^^^^^^^
= note: ...because `Default` has the bound `Sized`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_maybe_sized
= note: `-W clippy::needless-maybe-sized` implied by `-W clippy::suspicious`
= help: to override `-W clippy::suspicious` add `#[allow(clippy::needless_maybe_sized)]`
help: change the bounds that require `Sized`, or remove the `?Sized` bound
|
425 - impl<T: ?Sized + Default> Default for Mutex<T> {
425 + impl<T: Default> Default for Mutex<T> {
|
warning: `?Sized` bound is ignored because of a `Sized` requirement
--> library/std/src/sync/poison/mutex.rs:691:9
|
691 | impl<T: ?Sized + Default> Default for Mutex<T> {
| ^^^^^^
|
note: `T` cannot be unsized because of the bound
--> library/std/src/sync/poison/mutex.rs:691:18
|
691 | impl<T: ?Sized + Default> Default for Mutex<T> {
| ^^^^^^^
= note: ...because `Default` has the bound `Sized`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_maybe_sized
help: change the bounds that require `Sized`, or remove the `?Sized` bound
|
691 - impl<T: ?Sized + Default> Default for Mutex<T> {
691 + impl<T: Default> Default for Mutex<T> {
```
bors
added a commit
that referenced
this pull request
Jan 4, 2026
Rollup of 4 pull requests Successful merges: - #150201 (compiletest: Support revisions in debuginfo (read: debugger) tests) - #150225 (Weekly `cargo update`) - #150642 (mutex.rs: remove needless-maybe-unsized bounds) - #150658 (Clarify panic conditions in `Iterator::last`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jan 4, 2026
Rollup of 7 pull requests Successful merges: - #150201 (compiletest: Support revisions in debuginfo (read: debugger) tests) - #150642 (mutex.rs: remove needless-maybe-unsized bounds) - #150643 (vec in-place-drop: avoid creating an intermediate slice) - #150650 (Forbid generic parameters in types of #[type_const] items) - #150658 (Clarify panic conditions in `Iterator::last`) - #150659 (Add missing translator resources for interface parse_cfg and parse_check_cfg) - #150666 (Fix ambig-unambig-ty-and-consts link) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jan 4, 2026
Rollup merge of #150642 - hkBst:needless-maybe-sized-1, r=jhpratt mutex.rs: remove needless-maybe-unsized bounds Fixes for: ```text warning: `?Sized` bound is ignored because of a `Sized` requirement --> library/std/src/sync/nonpoison/mutex.rs:425:9 | 425 | impl<T: ?Sized + Default> Default for Mutex<T> { | ^^^^^^ | note: `T` cannot be unsized because of the bound --> library/std/src/sync/nonpoison/mutex.rs:425:18 | 425 | impl<T: ?Sized + Default> Default for Mutex<T> { | ^^^^^^^ = note: ...because `Default` has the bound `Sized` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_maybe_sized = note: `-W clippy::needless-maybe-sized` implied by `-W clippy::suspicious` = help: to override `-W clippy::suspicious` add `#[allow(clippy::needless_maybe_sized)]` help: change the bounds that require `Sized`, or remove the `?Sized` bound | 425 - impl<T: ?Sized + Default> Default for Mutex<T> { 425 + impl<T: Default> Default for Mutex<T> { | warning: `?Sized` bound is ignored because of a `Sized` requirement --> library/std/src/sync/poison/mutex.rs:691:9 | 691 | impl<T: ?Sized + Default> Default for Mutex<T> { | ^^^^^^ | note: `T` cannot be unsized because of the bound --> library/std/src/sync/poison/mutex.rs:691:18 | 691 | impl<T: ?Sized + Default> Default for Mutex<T> { | ^^^^^^^ = note: ...because `Default` has the bound `Sized` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_maybe_sized help: change the bounds that require `Sized`, or remove the `?Sized` bound | 691 - impl<T: ?Sized + Default> Default for Mutex<T> { 691 + impl<T: Default> Default for Mutex<T> { ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for: