Skip to content

Rollup of 2 pull requests #150655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 5 commits into from
Jan 4, 2026
Merged

Rollup of 2 pull requests #150655

bors merged 5 commits into from
Jan 4, 2026
+9 −9

Conversation

@matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Jan 3, 2026 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

reddevilmidzy and others added 5 commits January 3, 2026 00:16
@reddevilmidzy
Add tracking issue for sized_hierarchy
c7bb494
@reddevilmidzy
Move pattern_types and unqualified_local_imports to the tracking
3fc3226 
issue group
@Sekar-C-Mca
Fix typo in pattern usefulness documentation
65c1070 
Line 171 introduced `pt_1, .., pt_n` and `qt` as variable names, but
line 172 incorrectly used `tp_1, .., tp_n, tq`. This commit fixes the
inconsistency to use the correct variable names throughout.
@matthiaskrgr
Rollup merge of rust-lang#150596 - reddevilmidzy:add-tracking, r=BoxyUwU
24ba7d8 
Add tracking issue for sized_hierarchy

tracking issue rust-lang#144404
@matthiaskrgr
Rollup merge of rust-lang#150651 - Sekar-C-Mca:fix-pattern-usefulness…
c0c4525 
…-typo, r=nnethercote

Fix typo in pattern usefulness documentation

Line 171 introduced  and  as variable names, but
line 172 incorrectly used . This commit fixes the
inconsistency to use the correct variable names throughout.

Fixes rust-lang#149803
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 3, 2026
@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Jan 3, 2026

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Jan 3, 2026

📌 Commit c0c4525 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2026
@bors
Copy link
Collaborator

bors commented Jan 4, 2026

⌛ Testing commit c0c4525 with merge e25ee6b...

@bors
Copy link
Collaborator

bors commented Jan 4, 2026

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e25ee6b to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors bors merged commit e25ee6b into rust-lang:main Jan 4, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer
Copy link
Collaborator

rust-timer commented Jan 4, 2026

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#150596 Add tracking issue for sized_hierarchy 7e5eae9d85853dea1902299b2d7f631687b1a978 (link)
#150651 Fix typo in pattern usefulness documentation 0f9f27de30b340c2a292cedc7f5917e075e57b1f (link)

previous master: f57b9e6f56

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f57b9e6 (parent) -> e25ee6b (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e25ee6bac4a6a2867fee2d78103b178939759430 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2514.3s -> 3088.5s (+22.8%)
  2. dist-aarch64-apple: 6301.7s -> 7518.8s (+19.3%)
  3. aarch64-gnu-debug: 3992.2s -> 4711.8s (+18.0%)
  4. test-various: 6512.4s -> 7675.4s (+17.9%)
  5. dist-x86_64-apple: 6885.8s -> 8096.8s (+17.6%)
  6. arm-android: 5517.5s -> 6447.8s (+16.9%)
  7. x86_64-gnu-debug: 6840.5s -> 7951.6s (+16.2%)
  8. aarch64-apple: 9836.1s -> 11262.2s (+14.5%)
  9. aarch64-gnu-llvm-20-2: 2692.5s -> 3050.2s (+13.3%)
  10. i686-gnu-2: 5244.5s -> 5920.8s (+12.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Jan 4, 2026

Finished benchmarking commit (e25ee6b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.5% [-2.5%, -2.5%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.5% [-2.5%, -2.5%] 1

Cycles

Results (primary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.8% [-2.8%, -2.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.8% [-2.8%, -2.8%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.455s -> 473.697s (-0.16%)
Artifact size: 390.84 MiB -> 390.82 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr @bors @rust-timer @rustbot @reddevilmidzy @Sekar-C-Mca