Rollup of 5 pull requests #150674

matthiaskrgr · 2026-01-04T15:16:12Z

Successful merges:

test: add regression cases for valtree hashing ICE #150554 (test: add regression cases for valtree hashing ICE)
make specialization of Vec::extend and VecDeque::extend_front work for vec::IntoIter with any Allocator, not just Global #150597 (make specialization of Vec::extend and VecDeque::extend_front work for vec::IntoIter with any Allocator, not just Global)
alloc: Move Cow impl to existing ones #150619 (alloc: Move Cow impl to existing ones)
THIR pattern building: Pass HIR nodes instead of loose types/spans #150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans)
miri subtree update #150671 (miri subtree update)

r? @ghost
@rustbot modify labels: rollup

add `vpdpbusd` avx512 intrinsic

This commit adds basic support for FFI callbacks by registering a shim function via libffi. This shim function currently only exits with an error. The main motivation for this is to prevent miri segfaulting as described in [4639](rust-lang/miri#4639). In the future miri could try to continue execution in the registered callback, although as far as I understand Ralf that is no easy problem.

Basic support for FFI callbacks (at least stop segfaulting and report a proper error)

…r vec::IntoIter with any Allocator, not just Global

native lib support: support returning structs

android: get the entire test suite to pass

Right now, the `borrow.rs` module starts with a `Cow` impl, although most of them can be found below. This hurts code readability because there is `ToOwned` alongside its impl directly below it. Moving it to the others down below makes sense here, given that the entire enum depends on `ToOwned` anyways.

This updates the rust-version file to e8f3cfc.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: e8f3cfc Filtered ref: 5837f859c413e836e4fd1eb4985632c2f62c7db0 Upstream diff: rust-lang/rust@7fefa09...e8f3cfc This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

…and data operations

…ests/libc-pipe Refactor libc pipe tests to use utility functions for error handling and data operations

This should make it easier to keep track of where the types/spans came from.

This updates the rust-version file to f57b9e6.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: f57b9e6 Filtered ref: dd835ad11d6c5cea520a087bb620e3643e2dbf0f Upstream diff: rust-lang/rust@e8f3cfc...f57b9e6 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

add check_only feature for faster check builds

…gression-test, r=davidtwco test: add regression cases for valtree hashing ICE This PR extends the existing regression test `printing_valtrees_supports_non_values.rs` to cover cases that previously caused an ICE in `const_kind.rs` due to hashing inference variables. It specifically adds: A case where an associated constant is used without the required trait bound. The `0: _` case as suggested in [Here](rust-lang#150409 (comment)) Fixes rust-lang#150409

…cator, r=jhpratt make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global` These functions consume all the elements from the respective collection, but do not care about the `Allocator` they use. Without specifying one (like in `vec::IntoIter<T>`) the specialization is only chosen when `A=Global`. (extra context: `VecDeque::extend_front` is unstable and tracked by rust-lang#146975)

…ulacrum alloc: Move Cow impl to existing ones Right now, the `borrow.rs` module starts with a `Cow` impl, although most of them can be found below. This hurts code readability because there is `ToOwned` alongside its impl directly below it. Moving it to the others down below makes sense here, given that the entire enum depends on `ToOwned` anyways.

THIR pattern building: Pass HIR nodes instead of loose types/spans This should make it easier to keep track of where the types/spans came from. There should be no change to compiler output. --- In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for rust-lang#150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

miri subtree update Subtree update of `miri` to rust-lang/miri@5d149f2. Created using https://github.com/rust-lang/josh-sync. r? `@ghost`

matthiaskrgr · 2026-01-04T15:16:50Z

@bors r+ rollup=never p=5

bors · 2026-01-04T15:16:52Z

📌 Commit eeb4431 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2026-01-04T16:58:36Z

⌛ Testing commit eeb4431 with merge e29fcf4...

bors · 2026-01-04T20:15:02Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e29fcf4 to main...

rust-timer · 2026-01-04T20:16:31Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#150554	test: add regression cases for valtree hashing ICE	`542bc5d27a7dbc8ac21b50fe655c79af75d2403a` (link)
#150597	make specialization of `Vec::extend` and `VecDeque::extend_…	`4c50440380f8792608bd531db0a4c983dbb05730` (link)
#150619	alloc: Move Cow impl to existing ones	`cf41d5f26f12ba0aa6dde37109c3b06e9a0fb7f3` (link)
#150660	THIR pattern building: Pass HIR nodes instead of loose type…	`83ecbc0b99a56fe6020f1b5bba8d32c9358b21aa` (link)
#150671	miri subtree update	`75f7d939cbbf681e69b3728feb4e3a9b4bdfdcf6` (link)

previous master: 5afdf5d8c0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-01-04T20:18:21Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5afdf5d (parent) -> e29fcf4 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e29fcf45e4ae686d77b490bf07320f0d3a2cf35f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 6323.6s -> 8698.5s (+37.6%)
aarch64-gnu-llvm-20-1: 4061.0s -> 3300.1s (-18.7%)
aarch64-msvc-1: 7994.9s -> 6708.5s (-16.1%)
aarch64-apple: 11067.1s -> 9383.1s (-15.2%)
pr-check-1: 1962.8s -> 1680.7s (-14.4%)
aarch64-gnu-llvm-20-2: 3246.8s -> 2792.9s (-14.0%)
i686-gnu-2: 6182.5s -> 5358.7s (-13.3%)
aarch64-gnu-debug: 4565.8s -> 4000.7s (-12.4%)
x86_64-gnu-llvm-20-3: 7005.8s -> 6173.7s (-11.9%)
i686-gnu-1: 8403.2s -> 7431.2s (-11.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-01-04T20:56:30Z

Finished benchmarking commit (e29fcf4): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-2.9%, -2.9%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.624s -> 475.648s (0.01%)
Artifact size: 390.88 MiB -> 390.89 MiB (0.00%)

Dushyanthyadav and others added 30 commits December 31, 2025 21:09

test: add regression cases for valtree hashing ICE

4ba73c3

add vpdpbusd avx512 intrinsic

6453a17

Merge pull request rust-lang#4776 from folkertdev/vpdpbusd

e4a8675

add `vpdpbusd` avx512 intrinsic

minor cleanup

c7f6d78

Merge pull request rust-lang#4728 from weiznich/ffi_callbacks

6feaf1d

Basic support for FFI callbacks (at least stop segfaulting and report a proper error)

bump libffi

1f32c2a

avoid aliasing trouble around libffi closures

604cf92

make specialization of Vec::extend and VecDeque::extend_front work fo…

9a170fe

…r vec::IntoIter with any Allocator, not just Global

use a single generic codepath for all return types

4d2ce7d

Merge pull request rust-lang#4798 from RalfJung/native-lib-uniform-ret

e811227

native lib support: support returning structs

android: get the entire test suite to pass

296ab7c

Merge pull request rust-lang#4799 from RalfJung/android

2db68ef

android: get the entire test suite to pass

Prepare for merging from rust-lang/rust

b80a3ea

This updates the rust-version file to e8f3cfc.

Merge pull request rust-lang#4801 from rust-lang/rustup-2026-01-03

efdd313

Automatic Rustup

Refactor libc pipe tests to use utility functions for error handling …

aec6b9b

…and data operations

minor tweaks

b692fcb

Merge pull request rust-lang#4768 from hulxv/refactor/simplify-libc-t…

cb36523

…ests/libc-pipe Refactor libc pipe tests to use utility functions for error handling and data operations

Prefer to pass HIR nodes instead of loose types/spans

de37724

This should make it easier to keep track of where the types/spans came from.

Prepare for merging from rust-lang/rust

9302232

This updates the rust-version file to f57b9e6.

Merge pull request rust-lang#4802 from rust-lang/rustup-2026-01-04

f65c581

Automatic Rustup

add check_only feature for faster check builds

0557c75

Merge pull request rust-lang#4803 from RalfJung/check_only

dbf2ef7

add check_only feature for faster check builds

update lockfile

ff2acf0

matthiaskrgr added 2 commits January 4, 2026 16:16

Rollup merge of rust-lang#150671 - RalfJung:miri, r=RalfJung

eeb4431

miri subtree update Subtree update of `miri` to rust-lang/miri@5d149f2. Created using https://github.com/rust-lang/josh-sync. r? `@ghost`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026

bors merged commit e29fcf4 into rust-lang:main Jan 4, 2026
12 checks passed

rustbot added this to the 1.94.0 milestone Jan 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Rollup of 5 pull requests #150674

Rollup of 5 pull requests #150674

Uh oh!

matthiaskrgr commented Jan 4, 2026 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Jan 4, 2026

Uh oh!

bors commented Jan 4, 2026

Uh oh!

bors commented Jan 4, 2026

Uh oh!

bors commented Jan 4, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

rust-timer commented Jan 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Uh oh!

Rollup of 5 pull requests #150674

Rollup of 5 pull requests #150674

Uh oh!

Conversation

matthiaskrgr commented Jan 4, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Jan 4, 2026

Uh oh!

bors commented Jan 4, 2026

Uh oh!

bors commented Jan 4, 2026

Uh oh!

bors commented Jan 4, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Jan 4, 2026

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

matthiaskrgr commented Jan 4, 2026 •

edited by rustbot

Loading