Fix all non-bug lints. Switch to `let` statements.#56956

Closed

JohnHeitmann wants to merge 124 commits intorust-lang:masterfrom

JohnHeitmann:lints-submit

Commits on Dec 29, 2018

Commits on Jan 2, 2019

Clean up eslint pragma formatting
JohnHeitmann
committed

Commits on Jan 5, 2019

Use checked_add for adding time in recv_timeout

faern
authored and
JohnHeitmann
committed
Add documentation about panicking Add<Duration> impls

faern
authored and
JohnHeitmann
committed
Uninline some debugging code and use unlikely! macro

Zoxc
authored and
JohnHeitmann
committed
Store `Ident` rather than just `Name` in HIR types `Item` and `ForeignItem`.

alexreg
authored and
JohnHeitmann
committed
Implemented variants on type aliases in both ctor and pattern position.

alexreg
authored and
JohnHeitmann
committed
Added tests for feature.

alexreg
authored and
JohnHeitmann
committed
Made suggestion diagnostics more consistent for enum variant names, relative to method names.

alexreg
authored and
JohnHeitmann
committed
Fixed tests.

alexreg
authored and
JohnHeitmann
committed
Fixed more tests.

alexreg
authored and
JohnHeitmann
committed
Added chapter to Unstable Book.

alexreg
authored and
JohnHeitmann
committed
Fixed issues raised in first review.

alexreg
authored and
JohnHeitmann
committed
Work-around for shadowing of variant names with assoc const names in `libproc_macro/bridge/rpc.rs`.

alexreg
authored and
JohnHeitmann
committed
Added tests for enums & enum aliases with various combinations of generic args.

alexreg
authored and
JohnHeitmann
committed
Fixed issues raised in review.

alexreg
authored and
JohnHeitmann
committed
Expanded tests for enum variants with generic args.

alexreg
authored and
JohnHeitmann
committed
Removed unnecessary special handling of `VariantCtor` defs in `instantiate_value_path`.

alexreg
authored and
JohnHeitmann
committed
Fixed several ICEs.

alexreg
authored and
JohnHeitmann
committed
Added regression test for using generic parameters on modules.

alexreg
authored and
JohnHeitmann
committed
Fixed handling of unit variants of aliased enums in type NS.

alexreg
authored and
JohnHeitmann
committed
Fixed type inference for tuple struct variants.

alexreg
authored and
JohnHeitmann
committed
Fixed ICE when type arguments are specified on `Self` type.

alexreg
authored and
JohnHeitmann
committed
Minor clean-up

alexreg
authored and
JohnHeitmann
committed
Minor cosmetic changes

alexreg
authored and
JohnHeitmann
committed
Changed resolution of enum variants to low priority.

alexreg
authored and
JohnHeitmann
committed
Point at correct span for arguments in format strings

estebank
authored and
JohnHeitmann
committed
Add span label to unused string formatting argument

estebank
authored and
JohnHeitmann
committed
retrieve ty info from place_ty

csmoe
authored and
JohnHeitmann
committed
Fix typo in pin documentation

sgrif
authored and
JohnHeitmann
committed
Fix span in char documentation

estebank
authored and
JohnHeitmann
committed
Update references to closed issue

ids1024
authored and
JohnHeitmann
committed
resolve: Fix an ICE in import validation

petrochenkov
authored and
JohnHeitmann
committed
Give the crate select chevron room to breathe.
JohnHeitmann
committed
Removed aligned ZST requirement from docs of read_/write_unaligned.

kennytm
authored and
JohnHeitmann
committed
Update link to rustc guide

linclark
authored and
JohnHeitmann
committed
Suggest `.as_ref()` when appropriate for `Option` and `Result`

estebank
authored and
JohnHeitmann
committed
Clarify wording of E0512

varkor
authored and
JohnHeitmann
committed
Add specific diagnostic for transmuting between equal associated types

varkor
authored and
JohnHeitmann
committed
Fix warning when compiling rustc

varkor
authored and
JohnHeitmann
committed
remove remaining copyright headers

matthiaskrgr
authored and
JohnHeitmann
committed
resolve: Fix another ICE in import validation

petrochenkov
authored and
JohnHeitmann
committed
resolve: Never override real bindings with `Def::Err`s from error recovery

petrochenkov
authored and
JohnHeitmann
committed
Update cargo, rls, miri

ehuss
authored and
JohnHeitmann
committed
add non-copy note to stderr

csmoe
authored and
JohnHeitmann
committed
Fixed stderr files for ui tests.

alexreg
authored and
JohnHeitmann
committed
update tests line numbers

matthiaskrgr
authored and
JohnHeitmann
committed
resolve: Simplify treatment of ambiguity errors

petrochenkov
authored and
JohnHeitmann
committed
Use `same_type` instead of duplicating logic

estebank
authored and
JohnHeitmann
committed
Remove mention of required memory to build

nagisa
authored and
JohnHeitmann
committed
Improve error recovery for some built-in macros

petrochenkov
authored and
JohnHeitmann
committed
Make std::cmp::Ord documentation specify what it means to agree with PartialEq

czipperz
authored and
JohnHeitmann
committed
Specify criterion for PartialOrd

czipperz
authored and
JohnHeitmann
committed
Mention ToString in std::fmt docs

czipperz
authored and
JohnHeitmann
committed
Do not complain about missing crate named as a keyword

estebank
authored and
JohnHeitmann
committed
Refactor `UserTypeAnnotation`.

davidtwco
authored and
JohnHeitmann
committed
Always check well-formedness.

davidtwco
authored and
JohnHeitmann
committed
Add test for unreachable well-formedness.

davidtwco
authored and
JohnHeitmann
committed
Type annotations in associated constant patterns.

davidtwco
authored and
JohnHeitmann
committed
Add user type annotations to MIR dump.

davidtwco
authored and
JohnHeitmann
committed
Support user type annotations in `ref` bindings.

davidtwco
authored and
JohnHeitmann
committed
Add explicit error annotations to test.

davidtwco
authored and
JohnHeitmann
committed
Fix unresolved inference variable ICE.

davidtwco
authored and
JohnHeitmann
committed
Stop well-formedness checking unreachable code.

davidtwco
authored and
JohnHeitmann
committed
Stop duplicating projections of type annotation.

davidtwco
authored and
JohnHeitmann
committed
Guarantee `rustc_dump_user_substs` error order.

davidtwco
authored and
JohnHeitmann
committed
submodules: update clippy from f7bdf500 to 39bd8449

matthiaskrgr
authored and
JohnHeitmann
committed
Add `-Z instrument-mcount`

quark-zju
authored and
JohnHeitmann
committed
Address review comments: Remove new `PathResult` variant

estebank
authored and
JohnHeitmann
committed
Fix variable string size problem in transmute test

varkor
authored and
JohnHeitmann
committed
Group dep node data into a single structure

Zoxc
authored and
JohnHeitmann
committed
Use `entry` API to avoid double lookup when interning dep nodes

Zoxc
authored and
JohnHeitmann
committed
Address comments

Zoxc
authored and
JohnHeitmann
committed
Fix inconsistent Clone documentation.

doitian
authored and
JohnHeitmann
committed
Suggest using raw identifiers in 2018 edition when using keywords

estebank
authored and
JohnHeitmann
committed
Address review comments

estebank
authored and
JohnHeitmann
committed
Update tests after rebase

estebank
authored and
JohnHeitmann
committed
Account for `\xFF` and `\u{FF}` sequences in string format errors

estebank
authored and
JohnHeitmann
committed
Use structured suggestion for braceless unicode escape squence

estebank
authored and
JohnHeitmann
committed
use structured suggestions for nonexistent fields

euclio
authored and
JohnHeitmann
committed
Do not use unicode character in diagnostic help

estebank
authored and
JohnHeitmann
committed
privacy: Use common `DefId` visiting infra for all privacy visitors

petrochenkov
authored and
JohnHeitmann
committed
Address review comments

petrochenkov
authored and
JohnHeitmann
committed
Bound sgx target_env with fortanix as target_vendor

dingelish
authored and
JohnHeitmann
committed
Improve type mismatch error messages

codeworm96
authored and
JohnHeitmann
committed
Remove min_const_unsafe_fn since it is stable

dingelish
authored and
JohnHeitmann
committed
syntax: Fix regression in diagnostics for patterns in trait method parameters

petrochenkov
authored and
JohnHeitmann
committed
generate invalidations from 2-phase-borrow activations

nikomatsakis
authored and
JohnHeitmann
committed
adopt polonius-engine 0.6.2

nikomatsakis
authored and
JohnHeitmann
committed
Wf-check the output type of a function in MIR-typeck

matthewjasper
authored and
JohnHeitmann
committed
Add missing 'static bound for the Machine trait

matthewjasper
authored and
JohnHeitmann
committed
remove `commit_if_ok` wrapper

nikomatsakis
authored and
JohnHeitmann
committed
remove wrapper functions that had no purpose

nikomatsakis
authored and
JohnHeitmann
committed
make evaluation track whether outlives relationships mattered

nikomatsakis
authored and
JohnHeitmann
committed
introduce ability to detect region constraints from snapshot

nikomatsakis
authored and
JohnHeitmann
committed
select.rs: unsizing coercion should use a subtype

nikomatsakis
authored and
JohnHeitmann
committed
WIP: wfcheck ability to detect

nikomatsakis
authored and
JohnHeitmann
committed
universe transition

nikomatsakis
authored and
JohnHeitmann
committed
add tests exercising `exists<'a> { forall<'b> { .. } }` pattern

nikomatsakis
authored and
JohnHeitmann
committed
tests: move coherence-subtyping from run-pass to compile-fail

nikomatsakis
authored and
JohnHeitmann
committed
tests: worse diagnostics, but basically same errors

nikomatsakis
authored and
JohnHeitmann
committed
tests: cases where we now do the right thing but did not before

nikomatsakis
authored and
JohnHeitmann
committed
WIP other test changes

nikomatsakis
authored and
JohnHeitmann
committed
remove outdated `rustc_driver` tests

nikomatsakis
authored and
JohnHeitmann
committed
make `get_highlight_region_for_regionvid` only affect re-vid

nikomatsakis
authored and
JohnHeitmann
committed
dump out the exact state in error reporting debugs

nikomatsakis
authored and
JohnHeitmann
committed
generalize region highlights into a struct

nikomatsakis
authored and
JohnHeitmann
committed
add the ability to highlight placeholders

nikomatsakis
authored and
JohnHeitmann
committed
introduce placeholder-placeholder errors for trait matching

nikomatsakis
authored and
JohnHeitmann
committed
apply the new placeholder errors even with just one placeholder

nikomatsakis
authored and
JohnHeitmann
committed
refactor highlighting to take any RegionKind, making it more general

nikomatsakis
authored and
JohnHeitmann
committed
apply the same logic to ConcreteFailure errors

nikomatsakis
authored and
JohnHeitmann
committed
say "the lifetime" instead of "some lifetime" when it feels right

nikomatsakis
authored and
JohnHeitmann
committed
improve handling for subtype

nikomatsakis
authored and
JohnHeitmann
committed
pacify the mercilous tidy

nikomatsakis
authored and
JohnHeitmann
committed
address tmandry nits

nikomatsakis
authored and
JohnHeitmann
committed
add some comments about lifetimes etc

nikomatsakis
authored and
JohnHeitmann
committed
pacify the mercilous eddyb ;)

nikomatsakis
authored and
JohnHeitmann
committed
track if any region constraints involved placeholders

nikomatsakis
authored and
JohnHeitmann
committed
try to detect affected code and direct people to #56105

nikomatsakis
authored and
JohnHeitmann
committed
rename `type_moves_by_default` to `type_is_copy_modulo_regions`

nikomatsakis
authored and
JohnHeitmann
committed
Add optional eslint to the rustdoc-js test target
JohnHeitmann
committed
Delete buggy code that is probably dead
JohnHeitmann
committed

Uh oh!

Fix all non-bug lints. Switch to `let` statements.#56956JohnHeitmann wants to merge 124 commits intorust-lang:masterrust-lang/rust:masterfrom JohnHeitmann:lints-submitJohnHeitmann/rust:lints-submitCopy head branch name to clipboard

Commits

Commits on Dec 29, 2018

Commits on Jan 2, 2019

Commits on Jan 5, 2019

Fix all non-bug lints. Switch to `let` statements.#56956
JohnHeitmann wants to merge 124 commits intorust-lang:masterfrom
JohnHeitmann:lints-submit