Skip to content

Stabilize arbitrary_enum_discriminant, take 2 #95710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 2 commits into from
Oct 26, 2022
Merged

Stabilize arbitrary_enum_discriminant, take 2 #95710

bors merged 2 commits into from
Oct 26, 2022

Conversation

@fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Apr 6, 2022 •
edited
Loading

Documentation has been updated in rust-lang/reference#1055. cc #86860 for previous stabilization report.

Not yet marks #60553 as done: need documentation in the rust reference.

@fee1-dead fee1-dead added T-lang Relevant to the language team needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. labels Apr 6, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented Apr 6, 2022

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 6, 2022
@fee1-dead
Copy link
Member Author

fee1-dead commented Apr 6, 2022

r? @joshtriplett

@rust-highfive rust-highfive assigned joshtriplett and unassigned lcnr Apr 6, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fee1-dead fee1-dead force-pushed the stabilize_arbitrary_enum_discriminant branch from 7a7c77f to 9392d5c Compare April 6, 2022 02:35
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Apr 15, 2022

☔ The latest upstream changes (presumably #96087) made this pull request unmergeable. Please resolve the merge conflicts.

@davidli2010 davidli2010 mentioned this pull request Apr 27, 2022
Open
9 tasks
@fee1-dead
Copy link
Member Author

fee1-dead commented Jul 24, 2022

r? rust-lang/lang

@est31
Copy link
Member

est31 commented Aug 27, 2022

👋 Hello, I'm writing this comment in this stabilization PR to notify you, the authors of this PR, that #100591 has been merged, which implemented a change in how features are stabilized.

Your PR has been filed before the change, so will likely require modifications in order to comply with the new rules. I recommend you to:

  1. rebase the PR onto latest master, so that uses of the placeholder are possible.
  2. replace the version numbers in the PR with the placeholder CURRENT_RUSTC_VERSION. For language changes, this means the version numbers in accepted.rs (example: 4caedba). For library changes, this means the since fields (example e576a9b).

That's it! The CURRENT_RUSTC_VERSION placeholder will, as part of the release process, be replaced with the version number that the PR merged for. It can be used anywhere in rust-lang/rust, not just accepted.rs and the since fields.

If you have any questions, feel free to drop by the zulip stream, or ping me directly in this PR's thread. Thanks! 👋

@ARitz-Cracker
Copy link

ARitz-Cracker commented Sep 28, 2022

Hey, is there anything specific other than a rebase required for getting this merged? I've got a couple things that would greatly benefit from this!

@joshtriplett
Copy link
Member

joshtriplett commented Oct 3, 2022

This already went through an FCP. I think it just needs a rebase. LGTM, r=me when rebased.

@fee1-dead fee1-dead removed the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Oct 4, 2022
@fee1-dead fee1-dead force-pushed the stabilize_arbitrary_enum_discriminant branch from d53215b to 17125e9 Compare October 4, 2022 09:51
@ARitz-Cracker
Copy link

ARitz-Cracker commented Oct 4, 2022

Looks like the rebase happened, lookin' forward to this! 🥳

@fee1-dead
Copy link
Member Author

fee1-dead commented Oct 4, 2022

@bors r=joshtriplett

@bors
Copy link
Collaborator

bors commented Oct 4, 2022

📌 Commit 17125e9d0855d0b61168a08f57e6fb000afa4a16 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2022
@bors
Copy link
Collaborator

bors commented Oct 4, 2022

⌛ Testing commit 17125e9d0855d0b61168a08f57e6fb000afa4a16 with merge 372fa8229bd73882db533173b109e07ccd9f0f9f...

@bors
Copy link
Collaborator

bors commented Oct 4, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 4, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Oct 18, 2022

☔ The latest upstream changes (presumably #103188) made this pull request unmergeable. Please resolve the merge conflicts.

@fee1-dead fee1-dead force-pushed the stabilize_arbitrary_enum_discriminant branch from 17125e9 to b614b0e Compare October 22, 2022 06:29
@fee1-dead
Copy link
Member Author

fee1-dead commented Oct 23, 2022

Last CI error was spurious per https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/rustdoc-gui.20test.20failure/near/305520742.

@bors r=joshtriplett

@bors
Copy link
Collaborator

bors commented Oct 23, 2022

📌 Commit b614b0e has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 23, 2022
This was referenced Oct 24, 2022
Closed
Closed
Closed
@compiler-errors compiler-errors mentioned this pull request Oct 25, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 26, 2022
Merged
@bors bors merged commit 5b64553 into rust-lang:master Oct 26, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 26, 2022
@bors
Copy link
Collaborator

bors commented Oct 26, 2022

☔ The latest upstream changes (presumably #103572) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 26, 2022
@fee1-dead fee1-dead added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 3, 2022
@fee1-dead fee1-dead deleted the stabilize_arbitrary_enum_discriminant branch December 16, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joshtriplett joshtriplett

Labels

relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-lang Relevant to the language team

Projects

None yet

Milestone

1.66.0

Development

Successfully merging this pull request may close these issues.

10 participants

@fee1-dead @rust-highfive @rust-log-analyzer @bors @est31 @ARitz-Cracker @joshtriplett @pietroalbini @lcnr @rustbot