Skip to content

Conversation

@alexbool
Copy link
Contributor

No description provided.

@termoshtt
Copy link
Member

Thank PR. I think this could be a breaking change since the user code can assume num_complex::Complex<T> implements RustcEncodable and RustcDecodable.

@termoshtt termoshtt added the breaking change Non-compatible change label Jan 30, 2018
@termoshtt termoshtt modified the milestones: v0.5.0, 0.10 Jan 30, 2018
@termoshtt termoshtt merged commit b9ed2c9 into rust-ndarray:master Jan 30, 2018
@alexbool
Copy link
Contributor Author

Thanks!
While this is a breaking change in theory, I seriously doubt anyone will encounter this in reality.

@termoshtt
Copy link
Member

I think so, too. But we also have little reason to keep 0.9.x. Do you need a release for this?. I am intended to release the next version (0.10.0 or 0.9.1) after another PR, and this PR will be included there.

@alexbool
Copy link
Contributor Author

I don’t need this released ASAP, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Non-compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants