-
Notifications
You must be signed in to change notification settings - Fork 82
New releases: vhost v0.9.0 and vhost-user-backend v0.11.0 #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New releases: vhost v0.9.0 and vhost-user-backend v0.11.0 #193
Conversation
440f95f
to
346c21e
Compare
Marked as draft since we may want to merge others PR before the release, for example: |
@Ablu @aesteve-rh can you check the changelog changes we discussed in #187 (comment) ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
6a9ea7f
to
50e5c84
Compare
@stefano-garzarella does anything block dropping the DRAFT status? 🤔 |
I was waiting for #194 that I discovered yesterday after merging #116. (now is merged) The only one I'm thinking of is #190 (that is also breaking IIUC), but we need to wait a |
50e5c84
to
b4abd9f
Compare
No need to rush. Just tried to get a feeling of where we are. |
@stefano-garzarella Would be great to get the vm-memory bump (#190) in - vm-memory updates always create a lot of work (in terms of new crate release needs.) |
This is a bit annoying that we came into this situation... #190 depends on a bump of vm-memory in vm-virtio. Looks like vm-virtio was misconfigured and did not receive pokes from @dependabot to update the crate. Filed a PR to fix that (rust-vmm/vm-virtio#259). Now about updating vm-memory: I looked into doing that, but it is not so trivial. Migrating to the new VolatileRead/Write traits is not so straight-forward there. I added a comment on rust-vmm/vm-memory#247 (comment), trying to figure out a way forward. But I am not sure if it is solvable with the current API or may require some adapter between the rust-vmm and Rust's standard traits. All in all, this will probably take some time to settle as no one is actively working on doing the update. |
IMHO the last dependency before we can merge this is #200. Am I missing something? |
Yep, I think so. I'll rebase this. |
Release a new version with the following breaking changes: - replaced master/slave with frontend/backend in public API - replaced master/slave with frontend/backend in crate features Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Release a new version with the following breaking changes: - replaced master/slave with frontend/backend in public API - changed VhostUserBackend::handle_request() return type Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
b4abd9f
to
d48e848
Compare
Releases just published! |
So, can I try to update |
Thank you very much for the help! dependabot should do the update (I just asked here: rust-vmm/vhost-device#527 (comment)), but if there is any breaking change, we need to update the code. |
Summary of the PR
Preparation for a new release for both
vhost
andvhost-user-backend
I also run semver-checks:
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s
), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafe
code is properly documented.