Skip to content

Conversation

stefano-garzarella
Copy link
Member

Summary of the PR

Preparation for a new release for both vhost and vhost-user-backend

I also run semver-checks:

$ cargo semver-checks check-release
     Parsing vhost v0.9.0 (current)
     Parsing vhost v0.8.1 (baseline)
    Checking vhost v0.8.1 -> v0.9.0 (major change)
   Completed [   0.000s] 0 checks; 0 passed, 48 unnecessary
     Parsing vhost-user-backend v0.11.0 (current)
     Parsing vhost-user-backend v0.10.1 (baseline)
    Checking vhost-user-backend v0.10.1 -> v0.11.0 (major change)
   Completed [   0.000s] 0 checks; 0 passed, 48 unnecessary

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR are signed (with git commit -s), and the commit
    message has max 60 characters for the summary and max 75 characters for each
    description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@stefano-garzarella
Copy link
Member Author

Marked as draft since we may want to merge others PR before the release, for example:

@stefano-garzarella
Copy link
Member Author

@Ablu @aesteve-rh can you check the changelog changes we discussed in #187 (comment) ?

@stefano-garzarella stefano-garzarella changed the title Draft: prepare vhost and vhost-user-backend new releases New releases preparation: vhost v0.9.0 and vhost-user-backend v0.11.0 Sep 29, 2023
@stefano-garzarella stefano-garzarella mentioned this pull request Sep 29, 2023
4 tasks
Copy link
Contributor

@aesteve-rh aesteve-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sboeuf
sboeuf previously approved these changes Sep 29, 2023
Copy link
Collaborator

@sboeuf sboeuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ablu
Copy link
Collaborator

Ablu commented Oct 2, 2023

@stefano-garzarella does anything block dropping the DRAFT status? 🤔

@stefano-garzarella
Copy link
Member Author

@stefano-garzarella does anything block dropping the DRAFT status? 🤔

I was waiting for #194 that I discovered yesterday after merging #116. (now is merged)
I also pinged old PRs like #88 that we never merged, but maybe we should. Anyway, I don't see any answer yet, so we can postpone it.

The only one I'm thinking of is #190 (that is also breaking IIUC), but we need to wait a virtio-queue release first, so if we really need this release soon, we can postpone also that one.

@Ablu
Copy link
Collaborator

Ablu commented Oct 3, 2023

so if we really need this release soon, we can postpone also that one.

No need to rush. Just tried to get a feeling of where we are.

@stefano-garzarella stefano-garzarella marked this pull request as ready for review October 5, 2023 14:51
@stefano-garzarella
Copy link
Member Author

@eryugey @jiangliu @sboeuf @slp I marked this ready since I think #88 and #190 will take time, but I'm open to postpone this release to wait them.

@rbradford
Copy link
Contributor

rbradford commented Oct 5, 2023

@stefano-garzarella Would be great to get the vm-memory bump (#190) in - vm-memory updates always create a lot of work (in terms of new crate release needs.)

@Ablu
Copy link
Collaborator

Ablu commented Oct 5, 2023

This is a bit annoying that we came into this situation... #190 depends on a bump of vm-memory in vm-virtio. Looks like vm-virtio was misconfigured and did not receive pokes from @dependabot to update the crate. Filed a PR to fix that (rust-vmm/vm-virtio#259).

Now about updating vm-memory: I looked into doing that, but it is not so trivial. Migrating to the new VolatileRead/Write traits is not so straight-forward there. I added a comment on rust-vmm/vm-memory#247 (comment), trying to figure out a way forward. But I am not sure if it is solvable with the current API or may require some adapter between the rust-vmm and Rust's standard traits.

All in all, this will probably take some time to settle as no one is actively working on doing the update.

@Ablu
Copy link
Collaborator

Ablu commented Nov 7, 2023

IMHO the last dependency before we can merge this is #200. Am I missing something?

@stefano-garzarella
Copy link
Member Author

stefano-garzarella commented Nov 7, 2023

IMHO the last dependency before we can merge this is #200. Am I missing something?

Yep, I think so. I'll rebase this.

Release a new version with the following breaking changes:
- replaced master/slave with frontend/backend in public API
- replaced master/slave with frontend/backend in crate features

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Release a new version with the following breaking changes:
- replaced master/slave with frontend/backend in public API
- changed VhostUserBackend::handle_request() return type

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
@stefano-garzarella stefano-garzarella changed the title New releases preparation: vhost v0.9.0 and vhost-user-backend v0.11.0 New releases: vhost v0.9.0 and vhost-user-backend v0.11.0 Nov 7, 2023
@stefano-garzarella
Copy link
Member Author

This is now ready. @sboeuf @jiangliu @slp please take a look.

@stefano-garzarella
Copy link
Member Author

Releases just published!

@aesteve-rh
Copy link
Contributor

So, can I try to update vhost-device crates to use the new release already? Or is the process automatized?

@stefano-garzarella
Copy link
Member Author

So, can I try to update vhost-device crates to use the new release already? Or is the process automatized?

Thank you very much for the help!

dependabot should do the update (I just asked here: rust-vmm/vhost-device#527 (comment)), but if there is any breaking change, we need to update the code.
This should be the case here, but @Ablu already created this: rust-vmm/vhost-device#461 so maybe we just need to update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants