Make conventional easier to use
#20
Conversation
Unlike `Deref` or adding `AsRef<str>`, this allows us to decouple the lifetimes.
Previously, `Simple` would return values whose lifetimes were tied to `self` but really all the lifetimes are tied to the original `str` which is longer than `self`. This also validates that users get the correct lifetimes from `as_str` with `Typed`.
|
@JeanMertz any chance we can get progress on some of these issues? If things are still crazy for you, would you be willing to add me as a maintainer on github and crates.io so I can work to unblock myself? |
|
Hey @epage, things are less crazy, but still crazy enough to keep me away from open source contributions at the moment, unfortunately. I've added you to the repo and crates.io as a contributor, thanks for keeping the lights on while I'm gone 👍. |
|
Hey, sorry about this but the invitation expired (had to get setup on 2fa and got distracted from that). Can you re-invite? |
|
Since I haven't heard back, I've gone ahead and forked, for now, though I'd love to see the two crates merge back together eventually https://github.com/crate-ci/git-conventional
|
|
Sorry @epage, somehow I didn't get a notification about your reply, or I must have accidentally marked it as done. I've sent another invite, but am glad you found a way forward. Feel free to accept the invitation or keep working on your own fork 👍 I'll get back to more active maintainership soon, I've been using jilu some more recently and so plan on needing some of the improvements you've been making and proposing as well. |
2 participants
I've started porting my code to
conventional. I started withTypedbut I needed access to thestrs and ran into problems with that, so I thought I'd trySimple. Unfortunately, the lifetimes were off withSimpleso that didn't work also.