fix: dynamic branch links and StackBlitz functionality (#83) #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add deployment detection utility for dynamic URL generation - Fix hardcoded branch references in StackBlitz components - Update example generation with improved templates and configs - Add stackblitz.json for proper StackBlitz integration - Remove duplicate Tailwind imports causing styling conflicts - Add scripts for example generation and branch info injection - Add comprehensive tests for deployment detection - Fix linting errors and remove duplicate logger method - Remove problematic GitHub workflow This ensures StackBlitz links work correctly across all deployment contexts (main branch, PR previews, local development) and examples actually show working components instead of just basic apps.
github-actions
bot
added
status: in-code-review
|
🚀 Demo Preview Ready! Preview URL: https://demo.rozich.net/ag-grid-react-components-pr-90/ This preview will be available for testing until the PR is merged or closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the StackBlitz integration issues identified in #83:
Changes
1. Dynamic Branch Detection
src/utils/deployment.ts) that:2. Fixed StackBlitz Components
StackBlitzExample.tsxto use dynamic URLs instead of hardcoded branchSimpleStackBlitzExample.tsxto use dynamic GitHub links3. Enhanced Example Generation
create-stackblitz-examples.jswith better templates:4. StackBlitz Configuration
stackblitz.jsonfiles for proper StackBlitz integration5. Fixed Styling Issues
6. Additional Improvements
Testing
Test Plan
Fixes #83
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com