Skip to content

Conversation

zachharrison
Copy link
Contributor

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

></sqm-tax-and-cash>
);
};
// export const TaxAndCashTextProps = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented story

title: "Components/Microsite Portal Register",
};

// TODO: Figure out if we can delete this component and it's stories since we have a duplicate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO if we can delete the PortalRegistration componenet

@AndiLuo AndiLuo self-requested a review October 6, 2025 23:45
},
"dependencies": {
"@raisins/stencil-docs-target": "^1.1.0",
"@raisins/stencil-docs-target": "^1.2.0-1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flagging updating this at launch

Comment on lines +34 to +35
// height: "inherit",
// "justify-content": "space-between",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// height: "inherit",
// "justify-content": "space-between",

Comment on lines +1150 to +1151
{ name: "referralsMonth", route: "/(referralsMonth)/:status?" }, // TODO: Add status
{ name: "referralsWeek", route: "/(referralsWeek)/:status?" }, // TODO: Add status
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flagging TODO's

*/
@Component({
tag: "sqm-name-fields",
shadow: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should make sure this didn't break the form data somehow

Comment on lines +32 to +37
// styles?: {
// backgroundColor?: string;
// borderRadius?: string;
// border?: string;
// textColor?: string;
// };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// styles?: {
// backgroundColor?: string;
// borderRadius?: string;
// border?: string;
// textColor?: string;
// };

Comment on lines +91 to +93
// "&::part(base)": {
// border: "1px solid red",
// },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// "&::part(base)": {
// border: "1px solid red",
// },

error ? sheet.classes.inputErrorStyle : ""
}`}
exportparts="base: input-base, input: input-label"
// exportparts="base: input-base, input: input-field"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// exportparts="base: input-base, input: input-field"

return word[0].toUpperCase() + word.slice(1);
}

console.log(capitalizeFirstLetter("warning"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log(capitalizeFirstLetter("warning"));

<script type="module" src="build/mint-components.esm.js"></script>
<script nomodule src="build/mint-components.js"></script>
</head>
<!-- <script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this back to default index before launch

},
"dependencies": {
"@raisins/stencil-docs-target": "^1.1.1",
"@raisins/stencil-docs-target": "^1.2.0-2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flagging pre-release, need to launch raisins before this

@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 21:25
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR appears to be a comprehensive refactoring focused on standardizing styling and theming across the Mint Components library. The main purpose is to implement a unified branding configuration system while improving code organization and consistency.

Key changes include:

  • Implementation of a dynamic branding configuration system with CSS custom properties
  • Consolidation of import statements and file structure reorganization
  • Replacement of hardcoded style values with configurable CSS variables
  • Updates to component styling to use the new theming system

Reviewed Changes

Copilot reviewed 274 out of 282 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/stencilbook/src/stencil-storybook.tsx Code formatting changes from spaces to tabs
packages/mint-components/src/utils/utils.ts Added utility function for capitalizing strings with debug logging
packages/mint-components/src/utils/parseStates.ts New utility for parsing state configuration objects
packages/mint-components/src/templates/*.html Updated border styles to use CSS custom properties
packages/mint-components/src/tables/GenericTableView.tsx Replaced hardcoded colors with CSS variables
packages/mint-components/src/stories/PortalTemplates.stories.tsx Reorganized imports and removed readme references
packages/mint-components/src/saasquatch.d.ts Added comprehensive branding configuration interface
packages/mint-components/src/insertfont.ts New utility for dynamic font insertion
packages/mint-components/src/index.html Added branding configuration script and structure
packages/mint-components/src/global/styles.ts Major refactoring to support dynamic branding with CSS custom properties
packages/mint-components/src/global/mixins.ts Updated color references to use new CSS variables
packages/mint-components/src/global/global.ts Added branding configuration initialization logic
packages/mint-components/src/components/views/*.tsx Updated styling to use new theming system
packages/mint-components/src/components/tax-and-cash/**/*.tsx Extensive updates to use new styling system and fix import paths
Files not reviewed (2)
  • packages/bedrock-components/package-lock.json: Language not supported
  • packages/mint-components/package-lock.json: Language not supported
Comments suppressed due to low confidence (5)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants