-
Notifications
You must be signed in to change notification settings - Fork 1
All Changes related to content editor and Mint Component branding #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…h/program-tools into feature/content-editor
…h/program-tools into feature/content-editor
…h/program-tools into feature/content-editor
…m-tools into feature/content-editor
></sqm-tax-and-cash> | ||
); | ||
}; | ||
// export const TaxAndCashTextProps = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented story
title: "Components/Microsite Portal Register", | ||
}; | ||
|
||
// TODO: Figure out if we can delete this component and it's stories since we have a duplicate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO if we can delete the PortalRegistration componenet
}, | ||
"dependencies": { | ||
"@raisins/stencil-docs-target": "^1.1.0", | ||
"@raisins/stencil-docs-target": "^1.2.0-1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flagging updating this at launch
// height: "inherit", | ||
// "justify-content": "space-between", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// height: "inherit", | |
// "justify-content": "space-between", |
{ name: "referralsMonth", route: "/(referralsMonth)/:status?" }, // TODO: Add status | ||
{ name: "referralsWeek", route: "/(referralsWeek)/:status?" }, // TODO: Add status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flagging TODO's
*/ | ||
@Component({ | ||
tag: "sqm-name-fields", | ||
shadow: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should make sure this didn't break the form data somehow
// styles?: { | ||
// backgroundColor?: string; | ||
// borderRadius?: string; | ||
// border?: string; | ||
// textColor?: string; | ||
// }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// styles?: { | |
// backgroundColor?: string; | |
// borderRadius?: string; | |
// border?: string; | |
// textColor?: string; | |
// }; |
// "&::part(base)": { | ||
// border: "1px solid red", | ||
// }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// "&::part(base)": { | |
// border: "1px solid red", | |
// }, |
error ? sheet.classes.inputErrorStyle : "" | ||
}`} | ||
exportparts="base: input-base, input: input-label" | ||
// exportparts="base: input-base, input: input-field" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// exportparts="base: input-base, input: input-field" |
return word[0].toUpperCase() + word.slice(1); | ||
} | ||
|
||
console.log(capitalizeFirstLetter("warning")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log(capitalizeFirstLetter("warning")); |
<script type="module" src="build/mint-components.esm.js"></script> | ||
<script nomodule src="build/mint-components.js"></script> | ||
</head> | ||
<!-- <script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert this back to default index before launch
}, | ||
"dependencies": { | ||
"@raisins/stencil-docs-target": "^1.1.1", | ||
"@raisins/stencil-docs-target": "^1.2.0-2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flagging pre-release, need to launch raisins before this
…h/program-tools into feature/content-editor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR appears to be a comprehensive refactoring focused on standardizing styling and theming across the Mint Components library. The main purpose is to implement a unified branding configuration system while improving code organization and consistency.
Key changes include:
- Implementation of a dynamic branding configuration system with CSS custom properties
- Consolidation of import statements and file structure reorganization
- Replacement of hardcoded style values with configurable CSS variables
- Updates to component styling to use the new theming system
Reviewed Changes
Copilot reviewed 274 out of 282 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/stencilbook/src/stencil-storybook.tsx | Code formatting changes from spaces to tabs |
packages/mint-components/src/utils/utils.ts | Added utility function for capitalizing strings with debug logging |
packages/mint-components/src/utils/parseStates.ts | New utility for parsing state configuration objects |
packages/mint-components/src/templates/*.html | Updated border styles to use CSS custom properties |
packages/mint-components/src/tables/GenericTableView.tsx | Replaced hardcoded colors with CSS variables |
packages/mint-components/src/stories/PortalTemplates.stories.tsx | Reorganized imports and removed readme references |
packages/mint-components/src/saasquatch.d.ts | Added comprehensive branding configuration interface |
packages/mint-components/src/insertfont.ts | New utility for dynamic font insertion |
packages/mint-components/src/index.html | Added branding configuration script and structure |
packages/mint-components/src/global/styles.ts | Major refactoring to support dynamic branding with CSS custom properties |
packages/mint-components/src/global/mixins.ts | Updated color references to use new CSS variables |
packages/mint-components/src/global/global.ts | Added branding configuration initialization logic |
packages/mint-components/src/components/views/*.tsx | Updated styling to use new theming system |
packages/mint-components/src/components/tax-and-cash/**/*.tsx | Extensive updates to use new styling system and fix import paths |
Files not reviewed (2)
- packages/bedrock-components/package-lock.json: Language not supported
- packages/mint-components/package-lock.json: Language not supported
Comments suppressed due to low confidence (5)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description of the change
Type of change
Links
Checklists
Development
Paperwork
Code review