Get rid of appendToBody and introduce appendTo #1775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flexibility is needed as to where exactly the list gets appended to. Having only two options (to the
bodyand right after the main element) is not enough.The need to append the list somewhere else arose from this case where I needed to render the list inside a scrollable
divwithin a <dialog> element. The list would hide behind the boundary of the scrollablediv. To make it visible I had to append it to thedialogelement directly.This PR proposes getting rid of the
appenToBodyboolean and replacing it with a more generalappendToproperty. Seems like a breaking change, but hey, this is the next major.