-
Notifications
You must be signed in to change notification settings - Fork 230
CoCalc v2 #8453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
williamstein
wants to merge
1,116
commits into
master
Choose a base branch
from
fs2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CoCalc v2 #8453
+49,702
−59,694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
679fd15 to
6c7c0c0
Compare
…e leader client why? I got curious if codex could once and for all solve the subtle problem of multiple collaborative users of a terminal at once causing control code issues. It's just really tedious and I have put it off forever, but the problem is if multiple people have the same terminal open and a process in the project sends a message about terminal capabilities, all user terminals answer, whereas only one should. The right solution involves delegating one client to be a temporary leader, doing health checks, etc. It's tedious. Also you have to know whether data from the terminal is from the user or in response to capability/control messages... and I have never known how to do that -- codex has read the source code (I guess) of xterm.js, and it knew an undocumented non-public API that provides that info. With some back and forth, it works. 🤷
…y start with a control code ? User's don't type those.
…ficient (in terms of bandwidth)
(also right now save to disk may be buggy and this is causing pain sometime)
… work; "Text" --> "Rich Text"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.