chore: bump vitest deps #5622
Merged
chore: bump vitest deps #5622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsjtu
commented
Dec 2, 2025
Comment on lines
+39
to
47
|
|
||
| if (env === 'production') { | ||
| callback(); | ||
| // eslint-disable-next-line vitest/no-conditional-expect | ||
| expect(error).toHaveBeenCalledExactlyOnceWith(expectedError); | ||
| } else { | ||
| // eslint-disable-next-line vitest/no-conditional-expect | ||
| expect(callback).toThrowError(expectedError); | ||
| } |
Member
Author
There was a problem hiding this comment.
Bumping the vitest eslint version triggers this new linting error. Ignoring most of these for now, I fixed a few simple ones.
jhefferman-sfdc
approved these changes
Dec 2, 2025
Member
Author
|
/nucleus ignore -m 'downstream failures unrelated' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Closes #5584
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item