Move On Cancellation Logic to After Failure Hook #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+6
to
+7
| Delayed::Job sets this option to true by default, you will need to configure it to false | ||
| in order to include this library. |
There was a problem hiding this comment.
Should we include this in the README too?
There was a problem hiding this comment.
Added! thoughts?
jturkel
approved these changes
Sep 25, 2025
In order to allow individual jobs in the JobGroup to perform cleanup activities upon job failure, a JobGroups on cancellation job must be enqueued in the after failure delayed job lifecycle hook. If both were to be performed in the same hook, the job's failure hook and the on cancellation job may run at the same time since hook execution order is never guaranteed. This is particular important if the on cancellation job depends on state set in the failure hook of an individual job. This also forces the Delayed::Worker.destroy_failed_jobs to be set to false in order to prevent a race condition where a JobGroup could be completed (instead of cancelled) if a successful job occurs at the same time as a failing job.
marcoserrato
force-pushed
the
ms/move-on-cancellation-failure-hook
branch
from
fad8207 to
77f8014
Compare
erikkessler1
approved these changes
Sep 25, 2025
| $ rails generate delayed_job_groups_plugin:install | ||
| $ rake db:migrate | ||
|
|
||
| ## Upgrading from 0.14.0 |
There was a problem hiding this comment.
This is true for the initial installation too, right? If you're up for it, maybe it would be nice to include in the delayed_job_groups_plugin:install generator?
There was a problem hiding this comment.
Updated the generator to set the option, let me know what you think! Had to find a work around for being able to run the generator with the gem included, since generators run after railties run... We can assume the library hasn't been fully setup until the table is present, so we can skip raising the error in that case.
erikkessler1
approved these changes
Oct 6, 2025
| $ rails generate delayed_job_groups_plugin:install | ||
| $ rake db:migrate | ||
|
|
||
| ## Upgrading from 0.14.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed this issue.
Re-release #39 under a new major version
prime @jturkel @erikkessler1