Pages update #3024
Open
Pages update #3024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
th-2021
commented
Oct 11, 2024
th-2021
commented
- support gitlab with relative uri
- add namespace-in-path support
- add log-verbose option
Contributor
Author
|
fixes #2923 |
kkimurak
suggested changes
Jun 4, 2025
Contributor
kkimurak
left a comment
kkimurak
left a comment
There was a problem hiding this comment.
Generally looks good. I found 1 typo:
kkimurak
suggested changes
Jun 5, 2025
Contributor
kkimurak
left a comment
kkimurak
left a comment
There was a problem hiding this comment.
Sorry, I didn't notice that in my last review, but I just realized that we cannot set namespace_in_path to false. Can you check the review?
kkimurak
reviewed
Jun 7, 2025
kkimurak
approved these changes
Jun 7, 2025
Contributor
kkimurak
left a comment
kkimurak
left a comment
There was a problem hiding this comment.
Looks good to me. Wait for maintainer review and merge, Thank you for prompt response and contribution!
Contributor
Author
|
@sachilles can you please review this PR? Thanks |
Collaborator
|
@th-2021 Hopefully I'll find some time during this week in order to review your PR. Sorry for the delays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.