Skip to content

Conversation

jmgate
Copy link
Collaborator

@jmgate jmgate commented Dec 17, 2024

Type: Task

Description

Update the project config, CI, and docs to indicate support for Python 3.13.

Related Issues/PRs

Closes #157.

Summary by Sourcery

Add support for Python 3.13 by updating project configuration, CI workflows, and documentation.

Build:

  • Add Python 3.13 to the CI configuration matrix.

CI:

  • Update CI workflows to include testing for Python 3.13.

Documentation:

  • Update documentation to reflect support for Python 3.13.

@jmgate jmgate self-assigned this Dec 17, 2024
Copy link

sourcery-ai bot commented Dec 17, 2024

Reviewer's Guide by Sourcery

This PR adds Python 3.13 support by updating configuration files and documentation. The changes are straightforward, only requiring the addition of "3.13" to various files that specify Python version support.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added Python 3.13 to the CI workflow configuration
  • Added '3.13' to the matrix.version array in the CI workflow
.github/workflows/continuous-integration.yml
Updated documentation and metadata to include Python 3.13 support
  • Added Python 3.13 to the version badge in README
  • Added Python 3.13 classifier to project metadata
  • Updated documentation to reflect Python 3.13 support
README.md
pyproject.toml
doc/source/index.rst

Assessment against linked issues

Issue Objective Addressed Explanation
#157 Update CI to support Python 3.13
#157 Update documentation to indicate Python 3.13 support

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jmgate - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please verify compatibility with Python 3.13 alpha through testing before adding it to the supported versions. While the configuration changes are correct, we should ensure the codebase actually works with 3.13 first.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jmgate jmgate merged commit 04e2197 into master Dec 17, 2024
12 checks passed
@jmgate jmgate deleted the support-python-3.13 branch December 17, 2024 17:38
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (321bc90) to head (c0a242c).
Report is 49 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #161   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          180       180           
  Branches        15        15           
=========================================
  Hits           180       180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Python 3.13

1 participant