-
Notifications
You must be signed in to change notification settings - Fork 1
patch: Sign release commits and tags #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideCI workflow enhanced to produce GPG-signed release commits and tags by configuring python-semantic-release with SSH keys and committer metadata; an SSH key pair is generated, deploy key added to the repo, and both keys stored as environment secrets. Sequence Diagram: Signed Release Commit and Tag GenerationsequenceDiagram
participant Workflow as GitHub Actions Workflow
participant PSR as python-semantic-release action
participant Git
Workflow->>PSR: Run with inputs (committer_email, committer_name, ssh_private_signing_key, ssh_public_signing_key)
PSR->>Git: Configure committer details (name, email)
PSR->>Git: Configure SSH key for signing (using private_key)
Note over PSR,Git: python-semantic-release proceeds with release process
PSR->>Git: Create release commit(s)
PSR->>Git: Sign release commit(s)
PSR->>Git: Create release tag(s)
PSR->>Git: Sign release tag(s)
PSR->>Git: Push signed commit(s) and tag(s) to remote repository
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #207 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 180 180
Branches 15 15
=========================================
Hits 180 180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jmgate - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Type: Task
Description
This PR adds commit and tag signing to changes made by python-semantic-release in CI.
Motivation
Signing releases means we have a better security posture.
Implementation Details
release
environment.Summary by Sourcery
Configure the GitHub Actions release workflow to sign commits and tags using SSH keys
CI: