generated from sanity-io/nextjs-blog-cms-sanity-v3
-
Notifications
You must be signed in to change notification settings - Fork 108
feat: migrate to sanity-image, enhance page builder, update next-sanity #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kenjonespizza
wants to merge
26
commits into
main
Choose a base branch
from
feat-updates-images-and-page-builder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault fallback is still the dimensions of the image itself and made percentage so that naming convention is clear)
…eOptimistic bug, fix a bug with image uploads, add props for CTA/Info block so people can do custom createDataAttributes if needed
Bring updates into main of fork
…process, also update to new major next-sanity version because I thought that was the problem
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love Ken Jones. Left comments on a few files but things look good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Image System Overhaul & Page Builder Enhancements
This PR introduces significant improvements to the image handling system, enhances the page builder architecture, and modernizes the design system with better typography and visual editing support.
What to review
PageBuilder Improvements (See internal slack thread here)
useOptimistic
hook compatibility for drag-and-drop functionality in visual editingPageBuilderSection
type definitionEnhanced CTA Component
Major version bump: next-sanity v10.0.14 → v11.1.0
Replaced
next-sanity/image
withsanity-image
libraryCoverImage.tsx
componentSanityImage.tsx
wrapper component using thesanity-image
librarynext.config.ts
with proper remote patterns for securityDependencies & Upgrades
next-sanity
: v10.0.14 → v11.1.0sanity
: v4.5.0 → v4.8.1sanity-image
v1.0.0styled-components
(no longer needed on frontend/ ... right?)next-sanity
structureMisc minor changes
./client-utils
to@/app/client-utils
Testing
I know a lot of files changed here and testing woulda been simpler with less changes and a couple PR's, but this was initiated by a great PR by Johnny (we closed that PR since he wasn't merging changes into his fork)
Testing might be easiest by:
npm create sanity@latest -- --template https://github.com/sanity-io/sanity-template-nextjs-clean/tree/feat-updates-images-and-page-builder
and then importing sample content withnpm run import-sample-data