Add docker test target which can be easily run in concourse #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
force-pushed
the
docker-test-target
branch
9 times, most recently
from
5208e94 to
3fabf7c
Compare
SuperSandro2000
requested review from
Nuckal777,
VoigtS,
majewsky and
wagnerd3
as code owners
SuperSandro2000
force-pushed
the
docker-test-target
branch
from
3fabf7c to
00a1259
Compare
majewsky
requested changes
Oct 16, 2025
SuperSandro2000
force-pushed
the
docker-test-target
branch
2 times, most recently
from
76897ff to
a7e20f6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a Docker test stage to run static checks and coverage in CI (e.g., Concourse), while making REUSE checks optional and adding Postgres support where needed.
- Add a dedicated Dockerfile test stage to cache tool installation and run static checks/coverage.
- Make REUSE tooling conditional via cfg.Reuse.Enabled and propagate into Makefile targets and Dockerfile.
- Pass golang scan results into Dockerfile rendering; adjust .dockerignore and config to support test needs.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| main.go | Pass golang scan result into Dockerfile rendering to conditionally include test dependencies. |
| internal/makefile/makefile.go | Gate REUSE installation and checks behind reuseEnabled; adjust related prerequisites. |
| internal/dockerfile/dockerignore.tmpl | Stop ignoring files needed for linting/REUSE (e.g., LICENSE, config files). |
| internal/dockerfile/docker.go | Update RenderConfig to accept scan result; add test packages and ignores based on REUSE/Postgres. |
| internal/dockerfile/Dockerfile.tmpl | Add a “test” build stage that installs tools, runs static checks, and generates coverage. |
| internal/core/config.go | Introduce DockerfileConfig.ExtraTestPackages to allow project-specific test-time packages. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SuperSandro2000
force-pushed
the
docker-test-target
branch
from
a7e20f6 to
ebc1fdc
Compare
SuperSandro2000
force-pushed
the
docker-test-target
branch
from
e9d1106 to
4f0313b
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
1 similar comment
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see sapcc/keppel#604 and sapcc/limes#784