Add support for controller-gen applyconfiguration #392
+32
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwiesel
requested review from
Nuckal777,
SuperSandro2000,
VoigtS,
majewsky and
wagnerd3
as code owners
fwiesel
force-pushed
the
applyconfiguration
branch
from
8c3cfba to
e323624
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This is needed for making use of server-side apply in the controller-runtime. See the umbrella issue for details: kubernetes-sigs/controller-runtime#3183 It requires an opt-in via a comment , the same way you opt-in to the deep-copy functions.
majewsky
reviewed
Oct 16, 2025
There was a problem hiding this comment.
@Nuckal777 Can you please take a look? Most of us are not familiar with the kubebuilder stuff.
Nuckal777
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for making use of server-side apply in the controller-runtime.
See the umbrella issue for details: kubernetes-sigs/controller-runtime#3183
It requires an opt-in via a comment ,
the same way you opt-in to the deep-copy functions.