Skip to content

Conversation

@knightzac19
Copy link
Contributor

@knightzac19 knightzac19 commented Sep 23, 2024

This should address #163 and make it so pagination doesn't show up in an error occurs.

I should note though, this is the first time I've dealt with svelte, so if there's ways to improve what I've done, I'm all ears.

@vercel
Copy link

vercel bot commented Sep 23, 2024

@knightzac19 is attempting to deploy a commit to the satisfactorymodding Team on Vercel.

A member of the Team first needs to authorize it.

@knightzac19 knightzac19 marked this pull request as ready for review September 23, 2024 00:26
@vercel
Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
smr-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 0:31am

@knightzac19 knightzac19 force-pushed the update-search-error-msg branch from 7b5fbbe to a8ff5ef Compare September 23, 2024 15:33
budak7273
budak7273 previously approved these changes Sep 27, 2024
Copy link
Member

@budak7273 budak7273 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this works on my end. Added a tooltip to explain why the button is disabled since the disabled search button just looks like a normal button otherwise

@budak7273 budak7273 changed the title feat: fixed min search error message fix: min search error message Sep 29, 2024
@budak7273 budak7273 merged commit 9950e3e into satisfactorymodding:staging Oct 8, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed
Status: 🚢 Released

Development

Successfully merging this pull request may close these issues.

3 participants