-
Notifications
You must be signed in to change notification settings - Fork 40
Update an integration test failing when compiled with Java 21 #3103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...ion-test/src/main/java/com/scalar/db/api/DistributedTransactionAdminIntegrationTestBase.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces non-deterministic time-related test values with deterministic ones in an integration test. The change ensures test reproducibility by using fixed encoded values instead of now() method calls.
Key Changes
- Removed unused imports:
java.time.Instantandjava.time.ZoneId - Added import for
TimeRelatedColumnEncodingUtils - Replaced
LocalDate.now(ZoneId.of("UTC")),LocalTime.now(ZoneId.of("UTC")),Instant.now(), andLocalDateTime.now(ZoneOffset.UTC)with deterministic values usingTimeRelatedColumnEncodingUtils.decode*()methods
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ion-test/src/main/java/com/scalar/db/api/DistributedTransactionAdminIntegrationTestBase.java
Show resolved
Hide resolved
feeblefakie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
brfrn169
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
komamitsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
# Conflicts: # integration-test/src/main/java/com/scalar/db/api/DistributedTransactionAdminIntegrationTestBase.java
Description
I am currently upgrading ScalarDB Cluster JDK versions, and an integration test fails when being compiled with JDK 21. This fixes it.
Related issues and/or PRs
N/A
Changes made
Checklist
Additional notes (optional)
N/A
Release notes
N/A