Skip to content

Conversation

@Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented Oct 31, 2025

Description

I am currently upgrading ScalarDB Cluster JDK versions, and an integration test fails when being compiled with JDK 21. This fixes it.

Related issues and/or PRs

N/A

Changes made

  • Make sure time-related types test data do not use unsupported ranges.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@Torch3333 Torch3333 self-assigned this Oct 31, 2025
@Torch3333 Torch3333 changed the title Update integration test for cluster Update integration test for ScalarDB Cluster Nov 4, 2025
@Torch3333 Torch3333 changed the title Update integration test for ScalarDB Cluster Update integration test failing when compiled with Java 21 Nov 4, 2025
@Torch3333 Torch3333 changed the title Update integration test failing when compiled with Java 21 Update an integration test failing when compiled with Java 21 Nov 4, 2025
@Torch3333 Torch3333 marked this pull request as ready for review November 4, 2025 00:38
@Torch3333 Torch3333 requested review from a team, brfrn169, Copilot, feeblefakie and komamitsu and removed request for a team November 4, 2025 00:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces non-deterministic time-related test values with deterministic ones in an integration test. The change ensures test reproducibility by using fixed encoded values instead of now() method calls.

Key Changes

  • Removed unused imports: java.time.Instant and java.time.ZoneId
  • Added import for TimeRelatedColumnEncodingUtils
  • Replaced LocalDate.now(ZoneId.of("UTC")), LocalTime.now(ZoneId.of("UTC")), Instant.now(), and LocalDateTime.now(ZoneOffset.UTC) with deterministic values using TimeRelatedColumnEncodingUtils.decode*() methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 requested a review from komamitsu November 6, 2025 09:53
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@brfrn169 brfrn169 merged commit 8105889 into master Nov 6, 2025
131 of 132 checks passed
@brfrn169 brfrn169 deleted the fix_int_test_for_cluster branch November 6, 2025 23:53
Torch3333 added a commit that referenced this pull request Nov 7, 2025
# Conflicts:
#	integration-test/src/main/java/com/scalar/db/api/DistributedTransactionAdminIntegrationTestBase.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants