-
Notifications
You must be signed in to change notification settings - Fork 40
Add Maven publishing support for the ScalarDB Data Loader CLI module #3120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@thongdk8 Best to mention the description of why this is needed. The fact that just publishing the core library, which will be used in the Data Loader API server(for the web application), is not enough, as we need the full CLI code as a package as well. So that we can do the same like the schema loader in the cluster repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the data-loader CLI module from an executable application to a publishable Maven artifact. The key change replaces the application plugin with the maven-publish plugin and adds publishing configuration to enable Maven Central deployment.
- Removes the
applicationplugin and its configuration - Adds Maven publishing configuration with POM metadata
- Implements logic to conditionally disable fat jar creation during publishing
- Corrects the Main-Class attribute path in the shadowJar manifest
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds Maven publishing support for the scalardb-data-loader-cli module, which is a necessary step for its use in other modules like scalardb-cluster. The changes correctly set up the maven-publish plugin, configure the POM details, and fix an incorrect Main-Class path in the shadowJar configuration.
My review includes two main points:
- A suggestion to make the logic for disabling the
shadowJarduring publishing more robust by using Gradle's task graph. - A critical note about updating the root
build.gradleto include this new module in thejreleaserconfiguration, which is essential for the release process to work correctly.
Overall, the changes are good, but the missing update to the root build file is a significant issue that needs to be addressed.
Torch3333
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
ypeckstadt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
inv-jishnu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you.
komamitsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
brfrn169
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
feeblefakie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
This PR adds Maven publishing support for the scalardb-data-loader-cli module, allowing the CLI to be published as a Maven artifact.
Currently only scalardb-data-loader-core is published, which is mainly used by the Data Loader API server (web application). We now also need to publish the CLI module because it will be used inside scalardb-cluster to create the scalardb-cluster-data-loader-cli.
Related issues and/or PRs
NA
Changes made
maven-publishplugin to thedata-loader/cli/build.gradlefilescalardb-data-loader-cliscalardb-data-loader-cliand correct the main class config for theshadowJartaskChecklist
Additional notes (optional)
NA
Release notes
Added Maven publishing support for the ScalarDB Data Loader CLI, enabling distribution as a Maven artifact.