-
Notifications
You must be signed in to change notification settings - Fork 40
Backport to branch(3) : Add support for administrative operations in Blob adapter #3123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Toshihiro Suzuki <brfrn169@gmail.com>
Summary of ChangesHello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request backports a significant feature that enhances ScalarDB's capabilities by integrating administrative operations for object storage. It establishes a robust framework for managing namespaces and tables within object storage systems, starting with Azure Blob Storage. The changes include core logic for metadata handling, a generic wrapper for object storage interactions, and specific implementations for Blob storage, alongside extensive integration tests to ensure functionality. This allows for foundational data management tasks in object storage environments, while clearly defining and handling unsupported operations. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request backports support for administrative operations in the Blob adapter. It introduces new Gradle configurations and tasks for object storage integration tests, adds Azure Blob Storage as a new backend, and refines error messages related to unsupported administrative features. The changes also include new utility classes for object storage configuration, metadata handling, and a wrapper for Azure Blob Storage SDK interactions. Overall, the changes are well-structured and enhance the ScalarDB's capabilities with object storage.
core/src/main/java/com/scalar/db/storage/objectstorage/ConcatenationVisitor.java
Show resolved
Hide resolved
core/src/main/java/com/scalar/db/storage/objectstorage/ConcatenationVisitor.java
Show resolved
Hide resolved
core/src/main/java/com/scalar/db/storage/objectstorage/ConcatenationVisitor.java
Show resolved
Hide resolved
core/src/main/java/com/scalar/db/storage/objectstorage/ConcatenationVisitor.java
Show resolved
Hide resolved
core/src/main/java/com/scalar/db/storage/objectstorage/ConcatenationVisitor.java
Show resolved
Hide resolved
core/src/main/java/com/scalar/db/storage/objectstorage/ConcatenationVisitor.java
Show resolved
Hide resolved
core/src/main/java/com/scalar/db/storage/objectstorage/ConcatenationVisitor.java
Show resolved
Hide resolved
core/src/main/java/com/scalar/db/storage/objectstorage/ConcatenationVisitor.java
Show resolved
Hide resolved
core/src/main/java/com/scalar/db/storage/objectstorage/ConcatenationVisitor.java
Show resolved
Hide resolved
core/src/main/java/com/scalar/db/storage/objectstorage/ConcatenationVisitor.java
Show resolved
Hide resolved
core/src/main/java/com/scalar/db/storage/objectstorage/ObjectStorageProvider.java
Outdated
Show resolved
Hide resolved
|
@brfrn169 Could you take a glance at the changes in 7bc3e53? 🙏 Changes made:
|
brfrn169
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
This is an automated backport of the following:
Please merge this PR after all checks have passed.