feat(datawarehouse): add support for deployments, databases and users #3421
Conversation
jremy42
changed the title
jremy42
force-pushed
the
feat/datawarehouse_integration
branch
from
25d9e00 to
2a90b47
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3421 +/- ##
=========================================
- Coverage 1.66% 1.65% -0.02%
=========================================
Files 391 398 +7
Lines 43116 43539 +423
=========================================
+ Hits 720 722 +2
- Misses 42313 42734 +421
Partials 83 83 ☔ View full report in Codecov by Sentry. |
jremy42
force-pushed
the
feat/datawarehouse_integration
branch
8 times, most recently
from
d4d4d18 to
00245c3
Compare
jremy42
force-pushed
the
feat/datawarehouse_integration
branch
from
00245c3 to
abb244e
Compare
jremy42
changed the title
| tt := acctest.NewTestTools(t) | ||
| defer tt.Cleanup() | ||
|
|
||
| // Fetch a valid ClickHouse version to create a deployment |
There was a problem hiding this comment.
Could it be factored in a dedicated function?
| return datawarehouseapi.NewAPI(meta.ExtractScwClient(m)) | ||
| } | ||
|
|
||
| func expandStringList(list []any) []string { |
There was a problem hiding this comment.
Coud this function be migrated in the types package to be reused? Are we sure that there is no function in this package that already provide this feature?
|
|
||
| api := datawarehouse.NewAPI(tt.Meta) | ||
|
|
||
| versionsResp, err := api.ListVersions(&datawarehouseSDK.ListVersionsRequest{}, scw.WithAllPages()) |
There was a problem hiding this comment.
Could this be extracted in a function?
| } | ||
|
|
||
| func testSweepDatawarehouseDeployment(_ string) error { | ||
| return acctest.SweepRegions([]scw.Region{scw.RegionFrPar}, func(scwClient *scw.Client, region scw.Region) error { |
There was a problem hiding this comment.
Could it be possible to use datawarehouseSDK.Regions() here?
…icated helper function
… hardcoded region list
close #3102